fix(tui): handle session.error events in global sync - #48606
Open
OmarAlaaeldein wants to merge 1 commit into
Open
fix(tui): handle session.error events in global sync#48606OmarAlaaeldein wants to merge 1 commit into
OmarAlaaeldein wants to merge 1 commit into
Conversation
When a session fails and emits session.error, the TUI global sync reducer was ignoring it, leaving session_status in busy mode and the last assistant message without an error marker. Handle session.error by resetting session_status to idle and marking the assistant message error with finish: "error". Closes anomalyco#48530
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Related PR found:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #48530
Type of change
What does this PR do?
In the terminal TUI, when a session encounters an error and the server emits a
session.errorevent, the global sync reducer inpackages/tuiignored it. As a result:session_status[sessionID]remained permanently stuck inbusymode with an unending progress spinner.finish: "error".This PR adds a
session.errorhandler inpackages/tui/src/context/sync.tsx(the terminal counterpart to #48534 forpackages/app). Whensession.erroris received:session_status[sessionID]is reset to{ type: "idle" }.finish: "error".How did you verify your code works?
packages/tui/test/cli/cmd/tui/sync.test.tsxasserting thatsession.errorresets the session status toidleand marks the assistant message error and finish state.bun test test/cli/cmd/tui/sync.test.tsx(3/3 pass).bun run --cwd packages/tui typecheck(tsgo --noEmitpasses with 0 errors).Screenshots / recordings
N/A (TUI state reconciliation)
Checklist