GH-50697: [C++][FlightRPC] ODBC installer support fixes - #50748
Merged
Conversation
- Add installer description to ReadMe - Fix `docs` on Windows to include docs Co-authored-by: justing-bq <justin.gossett@improving.com>
github-actions
Bot
added
Component: C++
Component: FlightRPC
Component: Documentation
awaiting review
The installed file would be under `usr/share/doc/arrow2600-flight-sql-odbc-libs/connection-options.md`
alinaliBQ
added
CI: Extra: C++
alinaliBQ
marked this pull request as ready for review
July 31, 2026 17:27
alinaliBQ
requested review from
assignUser,
jonkeane,
kou,
lidavidm and
raulcd
as code owners
July 31, 2026 17:27
Collaborator
Author
|
Hi @kou cc @lidavidm, this PR is ready for review. The CI failures don't appear related to the code changes. Package Linux |
kou
approved these changes
Aug 1, 2026
github-actions
Bot
added
awaiting merge
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Collaborator
Author
|
I applied the change and the CI failures still look unrelated, some failures might be due to GitHub connection issue: C++ Extra / ODBC release AMD64 macOS 15-intel (pull_request): Package Linux / almalinux-8-amd64 (pull_request): |
Member
|
I kicked all the failing jobs |
lidavidm
approved these changes
Aug 5, 2026
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4dd7eb7. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GH-50697
I have tested the RPM ODBC installer on AlmaLinux 9. The ODBC driver works as expected on AlmaLinux 9. The only issue I found was that the
connection-options.mdguide was not included in the package installation. This PR addsconnection-options.mdto the RPM ODBC package so users can reference the connection options documentation after installation.Summary of testing results:
isqlandunixODBCduring installation.isqlandunixODBCas unused dependency during installation.If user wants to avoid this behavior, they can add
--noautoremoveflag to makednfkeepisqlandunixODBCduring ODBC uninstallation.What changes are included in this PR?
connection-options.mdto the RPM ODBC package installation./usr/share/doc/arrow2600-flight-sql-odbc-libs/connection-options.mdLICENSE.txtandNOTICE.txtREADME.mdAre these changes tested?
Yes
Are there any user-facing changes?
Yes