GH-51335: [CI][MATLAB] Fix Windows post-cache file locking error - #51336
Diveyam-Mishra wants to merge 1 commit into
Conversation
|
|
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain, and all reviewers assessed it as ready.
Pull request overview
Fixes two deterministic CI failures involving Windows MATLAB file locking and Debian pipx upgrades.
Changes:
- Cleans up lingering MSVC processes before cache finalization.
- Adds
--ignore-installedwhen upgradingpipx.
File summaries
| File | Summary |
|---|---|
ci/scripts/install_gcs_testbench.sh |
Prevents Debian pipx uninstall metadata errors. |
.github/workflows/matlab.yml |
Adds unconditional Windows compiler-process cleanup. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
The Matlab job is still failing on this PR.
Could you split those into two issues instead of grouping unrelated issues?
I'd like to merge the fix for gcs_testbench.sh to fix several nightly CI failures, let us know if you can do that on a separate PR.
github-actions
Bot
added
awaiting changes
|
The install_gcs_testbench issue has been fixed on a separate issue in order to fix several CI failures. Thanks for raising this one, let's repurpose it and focus only on the matlab issue. |
8381d36 to
516fae5
Compare
github-actions
Bot
added
awaiting change review
Diveyam-Mishra
changed the title
|
Who does run |
Rationale for this change
Resolves #51335.
AMD64 Windows 2022 MATLAB fails in post-job cache hashing (hashFiles('cpp/', 'matlab/') failed) because background MSVC compiler processes (mspdbsrv.exe, �ctip.exe) remain running with exclusive file handles open on generated files under cpp/.
What changes are included in this PR?
Add a cleanup step in .github/workflows/matlab.yml with if: always() to terminate lingering MSVC compiler daemons before post-job caching steps run.
Are these changes tested?
Yes, via CI.
Are there any user-facing changes?
No.