fix: drain all producer queues in SolaceIO publishResults, not just the current bundle's producer [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] - #39686
Open
waterWang wants to merge 1 commit into
Conversation
…t bundle's producer Fixes apache#39588 When multiple producers are configured, publishResults() only polled the current bundle producer's queue, losing results from other producers. Now it iterates over all producers and drains each queue.
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #39588
Problem: When multiple producers are configured in SolaceIO write,
publishResults()`` only polls thePublishedResultsQueue` of the current bundle's producer. Messages published by other producers in the same or previous bundles are never emitted to the downstream transform.Root cause:
publishResults()calledsolaceSessionServiceWithProducer()which returns the session forcurrentBundleProducerIndexonly. Queues of other producers (0 toproducersMapCardinality-1) were never polled.Fix: Iterate over all producer indices and drain each queue, so publish results from all producers are emitted. This matches the workaround described in the issue.
Wallet: fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT