CALCITE-7715 Remove HttpCore Timeout from BuiltInConnectionProperty - #318
Conversation
|
Can't you also remove the unused dependency? |
|
BTW: In our project we use Calcite but not Avatica connections, and excluding the http components explicitly in the Java build worked just fine, even without this change. |
Thanks for asking. The dependency itself is still required, so an intermediate step could be to mark the HTTP Components dependencies as optional, but that would require consuming projects to explicitly include them, instead of explicitly exclude them. |
|
In this case I am not sure that this change matches the justification in JIRA. As I said, if you don't use http, you can actually remove the dependencies already. |
The change is required for excluding those dependencies because |
|
Thanks for the review and feedback @mihaibudiu! |
CALCITE-7715 Removes the HttpCore 5
Timeoutclass reference from theBuiltInConnectionPropertyclasses and replaces it with the equivalent number of milliseconds to set the default Connection and Response Timeout properties.This change keeps references to HttpCore and HttpClient 5 localized to the Avatica Remote Client classes. With this change, integrating projects that do not need to perform remote HTTP operations with Calcite Avatica can exclude the HttpComponent dependencies without any issues at runtime.