[CALCITE-7731] Bound plain-notation expansion of DECIMAL literals to prevent parse-time OutOfMemoryError (follow-up, added more tests) - #5212
Merged
Conversation
Contributor
|
@skrcode thanks for the patch! LGTM |
rubenada
approved these changes
Aug 24, 2026
…prevent parse-time OutOfMemoryError (follow-up, added more tests)
skrcode
force-pushed
the
calcite-7731-tests
branch
from
August 24, 2026 09:51
d47bbf3 to
d905242
Compare
|
Contributor
|
Thanks for the patch @skrcode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Follow-up to #5204, requested by @rubenada in #5204 (comment).
This adds direct regression tests for the three CALCITE-7731 plain-notation guards outside the parser path:
Each test uses a bounded input of roughly 20,000 digits and verifies the specific guard exception. No production code changes are included.
Validation on current main with Java 21 and the pinned Gradle 8.14.4 wrapper:
The initial missing cases were identified by JAIPilot Cloud, then rebased, reviewed, and independently validated against the latest upstream main.