Skip to content

Lock table in DROP STATISTICS #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reshke wants to merge 1 commit into
base: REL_2_STABLE
Choose a base branch
from
+29 −10
Open

Lock table in DROP STATISTICS #2023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 29 additions & 10 deletions src/backend/commands/statscmds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,20 +741,14 @@ AlterStatistics(AlterStatsStmt *stmt)
}

/*
* Guts of statistics object deletion.
*/
void
RemoveStatisticsById(Oid statsOid)
* Delete entry in pg_statistic_ext_data catalog.
*/
static void
RemoveStatisticsDataById(Oid statsOid)
{
Relation relation;
HeapTuple tup;
Form_pg_statistic_ext statext;
Oid relid;

/*
* First delete the pg_statistic_ext_data tuple holding the actual
* statistical data.
*/
relation = table_open(StatisticExtDataRelationId, RowExclusiveLock);

tup = SearchSysCache1(STATEXTDATASTXOID, ObjectIdGetDatum(statsOid));
Expand All @@ -767,6 +761,19 @@ RemoveStatisticsById(Oid statsOid)
ReleaseSysCache(tup);

table_close(relation, RowExclusiveLock);
}

/*
* Guts of statistics object deletion.
*/
void
RemoveStatisticsById(Oid statsOid)
{
Relation relation;
Relation rel;
HeapTuple tup;
Form_pg_statistic_ext statext;
Oid relid;

/*
* Delete the pg_statistic_ext tuple. Also send out a cache inval on the
Expand All @@ -782,12 +789,24 @@ RemoveStatisticsById(Oid statsOid)
statext = (Form_pg_statistic_ext) GETSTRUCT(tup);
relid = statext->stxrelid;

/*
* Delete the pg_statistic_ext_data tuple holding the actual statistical
* data. We lock the user table first, to prevent other processes (e.g.
* DROP STATISTICS) from removing the row concurrently.
*/
rel = table_open(relid, ShareUpdateExclusiveLock);

RemoveStatisticsDataById(statsOid);

CacheInvalidateRelcacheByRelid(relid);

CatalogTupleDelete(relation, &tup->t_self);

ReleaseSysCache(tup);

/* Keep lock until the end of the transaction. */
table_close(rel, NoLock);

table_close(relation, RowExclusiveLock);
}

Expand Down
Loading