network: skip dhcp and dns health checks on internal LB routers - #14106
Open
nagaboinaramgopal wants to merge 1 commit into
Open
network: skip dhcp and dns health checks on internal LB routers#14106nagaboinaramgopal wants to merge 1 commit into
nagaboinaramgopal wants to merge 1 commit into
Conversation
An internal LB VM runs only the load balancer, but it was given the full virtual router health check set, so the dhcp and dns checks failed on every advanced health check run and flooded the event log. Exclude those checks for a router whose role is internal LB, using the existing per-router excluded-checks mechanism. Fixes: apache#12658
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #14106 +/- ##
============================================
+ Coverage 16.34% 16.37% +0.02%
- Complexity 13576 13596 +20
============================================
Files 5669 5669
Lines 501405 501477 +72
Branches 60907 60915 +8
============================================
+ Hits 81975 82111 +136
+ Misses 410246 410164 -82
- Partials 9184 9202 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An internal LB VM runs only the load balancer, but it is configured with the full virtual router health check set. The dhcp and dns checks have nothing to verify on an internal LB, so they fail on every advanced health check run and flood the event log with failures every few minutes.
This excludes the dhcp and dns checks for a router whose role is internal LB, using the existing per-router excluded-checks mechanism (the same one that already excludes the gateway check on backup routers).
Fixes: #12658
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
N/A
How Has This Been Tested?
Added a unit test on createMonitorServiceCommand: for a router whose role is internal LB, the excluded health checks now include dhcp_check.py and dns_check.py. Before this change the excluded set is empty for that router and the test fails. The existing appliance-manager tests still pass.
How did you try to break this feature and the system with this change?
The exclusion is gated on the internal LB role, so a normal virtual router or VPC router is unaffected. The change only appends to the existing excluded-checks list, alongside the backup-router gateway-check exclusion that is already there.