reject kPackInfo with missing pack sizes in readPackInfo - #808
Open
kali834x wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readPackInfo reads the numPackStreams field but only allocates and fills archive.packSizes inside the optional kSize property block, so a crafted 7z whose kPackInfo declares a non-zero packed stream count and omits kSize leaves packSizes as the default empty array. the sanity pass does not catch it: sanityCheckPackInfo sets numberOfPackedStreams from the declared count whether or not kSize is present, so the count comparison in sanityCheckUnpackInfo still matches. calculateStreamMap then builds a zero-length packStreamOffsets while folderFirstPackStreamIndex[0] stays 0, and the first getNextEntry indexes archive.packSizes[0] in buildDecoderStack and packStreamOffsets[0] in reopenFolderInputStream, throwing ArrayIndexOutOfBoundsException out of getNextEntry which only declares IOException. require packSizes.length to equal the declared count in readPackInfo, mirroring the isEmpty(packSizes) guard the encoded-header path already has; an archive that legitimately declares zero packed streams still passes since 0 == 0.
mvn; that'smvnon the command line by itself.