[COMPRESS-725] Use ArchiveEntry.resolveIn in ArchiveStreamFactory decompress example - #810
Open
tanvir-ux wants to merge 1 commit into
Open
[COMPRESS-725] Use ArchiveEntry.resolveIn in ArchiveStreamFactory decompress example#810tanvir-ux wants to merge 1 commit into
tanvir-ux wants to merge 1 commit into
Conversation
The class-level ZIP decompress Javadoc used Path.resolve(entry.getName()), which is vulnerable to Zip Slip if copied as-is. Prefer ArchiveEntry.resolveIn (available since 1.26.0), the same guard Expander uses.
uros-b
approved these changes
Aug 29, 2026
Member
|
Good catch @tanvir-ux! |
Author
|
Thanks @uros-b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes COMPRESS-725.
The class-level "Decompressing a ZIP-File" example in
ArchiveStreamFactoryused:That pattern is vulnerable to Zip Slip if copied into application code. Commons Compress already provides
ArchiveEntry.resolveIn(Path)(since 1.26.0) as the safe extraction helper used byExpander.This PR updates the example to:
Documentation-only; no behavioral change.
Testing