docs: correct Spark 4.2 version and CI test status in installation guide - #5315
Open
andygrove wants to merge 1 commit into
Open
docs: correct Spark 4.2 version and CI test status in installation guide#5315andygrove wants to merge 1 commit into
andygrove wants to merge 1 commit into
Conversation
The installation guide listed the experimental Spark 4.2 support as targeting `4.2.0-preview4` and claimed no Comet tests run in CI. Both are stale: - The `spark-4.2` Maven profile targets the `4.2.0` final release. - `pr_build_linux.yml` includes a "Spark 4.2, JDK 17" job in the `linux-test` matrix, so Comet tests do run in CI. Spark SQL tests still do not run for 4.2 (no `spark_4_2` job in `ci.yml`), so that column stays "No" and the version remains experimental. Also refresh the two `4.2.0-preview4` examples in the contributor guide, which cited a version Comet no longer targets, to use a hypothetical future release instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — docs correction spotted while reading the installation guide.
Rationale for this change
The experimental-versions table in the installation guide has two stale claims about Spark 4.2:
4.2.0-preview4, but thespark-4.2Maven profile inpom.xmltargets the4.2.0final release (<spark.version>4.2.0</spark.version>)..github/workflows/pr_build_linux.ymlhas a"Spark 4.2, JDK 17"entry in thelinux-testmatrix, so Comet tests do run for 4.2.What changes are included in this PR?
installation.md: experimental table row becomes4.2.0with "Comet Tests in CI: Yes".compatibility/spark-versions.md: drop the-preview4suffix and reword the warning, which claimed 4.2 support "targets a preview release of Spark".adding_a_new_spark_version.md: the two4.2.0-preview4examples cited a version Comet no longer targets; switched to a hypothetical future release so they keep illustrating the release-qualifier point.Spark SQL tests still do not run for 4.2 — there is no
spark_4_2job inci.yml— so that column stays "No" and 4.2 remains in the experimental tier. Per the promotion criteria inadding_a_new_spark_version.md, promotion to "Supported" requires both CI columns to be "Yes", so this PR intentionally does not promote it.How are these changes tested?
Docs only.
npx prettierreports no changes for all three files.