Skip to content

fix: Fix nullability of logical InSubquery expression - #23429

Open
AdamGS wants to merge 2 commits into
apache:mainfrom
AdamGS:adamg/fix-23428
Open

fix: Fix nullability of logical InSubquery expression #23429
AdamGS wants to merge 2 commits into
apache:mainfrom
AdamGS:adamg/fix-23428

Conversation

@AdamGS

@AdamGS AdamGS commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Report correct nullability for InSubquery logical exprs.

What changes are included in this PR?

OR the expression's and the subquery's nullability, more like ScalarSubquery.

Are these changes tested?

  1. Targeted unit tests InSubquery nullability
  2. Unit tests to verify the expression simplifier handles these queries correctly.

Are there any user-facing changes?

No

@github-actions github-actions Bot added logical-expr Logical plan and expressions optimizer Optimizer rules labels Jul 9, 2026
@AdamGS AdamGS changed the title Adamg/fix 23428 fix: Fix nullability of logical InSubquery expression Jul 9, 2026
@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.88%. Comparing base (62650ef) to head (a1a4508).

Files with missing lines Patch % Lines
datafusion/expr/src/expr_schema.rs 97.72% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #23429   +/-   ##
=======================================
  Coverage   80.87%   80.88%           
=======================================
  Files        1101     1101           
  Lines      375765   375827   +62     
  Branches   375765   375827   +62     
=======================================
+ Hits       303915   303975   +60     
+ Misses      53747    53746    -1     
- Partials    18103    18106    +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AdamGS added 2 commits August 3, 2026 13:43
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logical InSubquery only take the expression nullability into account

2 participants