fix: ensure new_list respects data_type argument - #24029
Open
Ruchirtripathi wants to merge 4 commits into
Open
Conversation
Contributor
|
@Ruchirtripathi Thanks for the contribution! Can you take a look at the test failures, please? |
Ruchirtripathi
force-pushed
the
fix-scalar-value-new-list
branch
2 times, most recently
from
August 1, 2026 03:35
6bfdcf2 to
55e5063
Compare
…chema in array_agg accumulators
Ruchirtripathi
force-pushed
the
fix-scalar-value-new-list
branch
from
August 1, 2026 04:05
55e5063 to
1239b46
Compare
Author
|
Hi! I've pushed a new commit that resolves the CI errors while maintaining the strict contract for #24022. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24029 +/- ##
==========================================
- Coverage 80.85% 80.85% -0.01%
==========================================
Files 1101 1101
Lines 375467 375487 +20
Branches 375467 375487 +20
==========================================
+ Hits 303596 303605 +9
- Misses 53777 53784 +7
- Partials 18094 18098 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Fixes a bug where
ScalarValue::new_list,new_list_nullable, andnew_large_listsilently ignored thedata_typeargument when thevaluesarray was non-empty. This caused issues where accumulators likecollect_listcould produce outputs with a slightly different type than declared (e.g., in the nullability ofnested fields), leading to invalid argument errors in
GroupedHashAggregateStream::emit.What changes are included in this PR?
cast_with_optionscall for non-empty lists inScalarValue::new_list,new_list_from_iter, andnew_large_list.DEFAULT_CAST_OPTIONSto ensure the concatenated array is properly reconciled with the requesteddata_type.Are these changes tested?
Yes, this is covered by existing tests. It resolves the
GroupedHashAggregateStreamoutput batch validationfailures for accumulators.
Are there any user-facing changes?
No, this is an internal bug fix.