docs: Add more documentation about PartialSortExec operator - #24048
Open
alamb wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
FYI @NGA-TRAN per our disucssion |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24048 +/- ##
==========================================
- Coverage 80.86% 80.85% -0.01%
==========================================
Files 1101 1101
Lines 375444 375446 +2
Branches 375444 375446 +2
==========================================
- Hits 303593 303578 -15
- Misses 53764 53775 +11
- Partials 18087 18093 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2010YOUY01
approved these changes
Aug 2, 2026
2010YOUY01
left a comment
Contributor
There was a problem hiding this comment.
LGTM, this is a great doc improvement.
| /// +---+---+---+ | ||
| /// ``` | ||
| /// | ||
| /// Once known complete, the uffered rows are sorted by the full `(a, b, c)` |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Once known complete, the uffered rows are sorted by the full `(a, b, c)` | |
| /// Once known complete, the buffered rows are sorted by the full `(a, b, c)` |
NGA-TRAN
approved these changes
Aug 2, 2026
NGA-TRAN
left a comment
Contributor
There was a problem hiding this comment.
Make sense. Thanks Andrew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
I was trying to explain to someone recently how PartialSortExec works, and I found the
datafusion docs weren't quite as explicit about the befits as I wanted
What changes are included in this PR?
Are these changes tested?
By CI
Are there any user-facing changes?
Better docs