Skip to content

Updates cross-language-testing #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
leerho wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Updates cross-language-testing #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 53 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,12 @@ under the License.
<org-slf4j.version>2.0.12</org-slf4j.version> <!-- used by TestNG -->
<!-- these are TestNG groups used for excluding / including groups of tests. See profiles section. -->
<testng.generate-java-files>generate_java_files</testng.generate-java-files>
<testng.check-java-files>check_java_files</testng.check-java-files>
<testng.check-cpp-files>check_cpp_files</testng.check-cpp-files>
<testng.check-go-files>check_go_files</testng.check-go-files>
<testng.check-cpp-historical-files>check_cpp_historical_files</testng.check-cpp-historical-files>
<test.data.root>${project.basedir}</test.data.root>
<project.root>${project.basedir}</project.root>

<!-- JVM arguments -->
<jvm.mem>-Xmx4g</jvm.mem>
Expand Down Expand Up @@ -373,6 +376,7 @@ under the License.
<version>${maven-javadoc-plugin.version}</version>
<configuration>
<locale>en_US</locale>
<overview>${project.basedir}/src/main/javadoc/overview.html</overview>
<outputDirectory>${project.reporting.outputDirectory}</outputDirectory>
<docfilessubdirs>true</docfilessubdirs>
<show>public</show>
Expand Down Expand Up @@ -480,6 +484,10 @@ under the License.
<value>0</value>
</property>
</properties>
<systemPropertyVariables>
<test.data.root>${test.data.root}</test.data.root>
<project.root>${project.root}</project.root>
</systemPropertyVariables>
</configuration>
</plugin>

Expand Down Expand Up @@ -728,7 +736,33 @@ under the License.
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<groups>${testng.generate-java-files}</groups>
<excludedGroups>${testng.check-cpp-files},${testng.check-go-files},${testng.check-cpp-historical-files}</excludedGroups>
<excludedGroups>
${testng.check-java-files},
${testng.check-cpp-files},
${testng.check-go-files},
${testng.check-cpp-historical-files}
</excludedGroups>
</configuration>
</plugin>
</plugins>
</build>
</profile>

<profile>
<id>check-java-files</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<groups>${testng.check-java-files}</groups>
<excludedGroups>
${testng.generate-java-files},
${testng.check-cpp-files},
${testng.check-go-files},
${testng.check-cpp-historical-files}
</excludedGroups>
</configuration>
</plugin>
</plugins>
Expand All @@ -744,7 +778,12 @@ under the License.
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<groups>${testng.check-cpp-files}</groups>
<excludedGroups>${testng.generate-java-files},${testng.check-go-files},${testng.check-cpp-historical-files}</excludedGroups>
<excludedGroups>
${testng.generate-java-files},
${testng.check-java-files},
${testng.check-go-files},
${testng.check-cpp-historical-files}
</excludedGroups>
</configuration>
</plugin>
</plugins>
Expand All @@ -760,7 +799,12 @@ under the License.
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<groups>${testng.check-go-files}</groups>
<excludedGroups>${testng.generate-java-files},${testng.check-cpp-files},${testng.check-cpp-historical-files}</excludedGroups>
<excludedGroups>
${testng.generate-java-files},
${testng.check-java-files},
${testng.check-cpp-files},
${testng.check-cpp-historical-files}
</excludedGroups>
</configuration>
</plugin>
</plugins>
Expand All @@ -776,7 +820,12 @@ under the License.
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<groups>${testng.check-cpp-historical-files}</groups>
<excludedGroups>${testng.generate-java-files},${testng.check-go-files},${testng.check-cpp-files}</excludedGroups>
<excludedGroups>
${testng.generate-java-files},
${testng.check-java-files},
${testng.check-go-files},
${testng.check-cpp-files}
</excludedGroups>
</configuration>
</plugin>
</plugins>
Expand Down
6 changes: 3 additions & 3 deletions src/main/javadoc/overview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<head>
</head>
<body>
<h1>Sketching Core Library</h1>
<h1>Sketching Core Library For Java</h1>
<h2>Overview</h2>

<p>The Sketching Core Library provides a range of stochastic streaming algorithms and closely
Expand All @@ -33,9 +33,9 @@ <h2>Overview</h2>

<p>This library is divided into packages that constitute distinct groups of functionality:</p>

Note: In general, if the requirements or promises of any method's contract are not fulfilled
<p>Note: In general, if the requirements or promises of any method's contract are not fulfilled
(that is, if there is a bug in either the method or its caller),
then an unchecked exception will be thrown.
The precise type of such an unchecked exception does not form part of any method's contract.
The precise type of such an unchecked exception does not form part of any method's contract.</p>
</body>
</html>
142 changes: 0 additions & 142 deletions src/test/java/org/apache/datasketches/common/TestUtil.java
View file
Open in desktop

This file was deleted.

9 changes: 1 addition & 8 deletions src/test/java/org/apache/datasketches/common/UtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
package org.apache.datasketches.common;

import static java.lang.Math.pow;
import static org.apache.datasketches.common.TestUtil.cppPath;
import static org.apache.datasketches.common.TestUtil.javaPath;
import static org.apache.datasketches.common.Util.bytesToInt;
import static org.apache.datasketches.common.Util.bytesToLong;
import static org.apache.datasketches.common.Util.bytesToString;
Expand Down Expand Up @@ -56,7 +54,6 @@
import static org.apache.datasketches.common.Util.zeroPad;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertNotNull;
import static org.testng.Assert.assertTrue;
import static org.testng.Assert.fail;

Expand Down Expand Up @@ -436,11 +433,7 @@ static void checkCeilingMultiple2expK() {
assertEquals(v, v2);
}

@Test
public void checkDirCreation() {
assertNotNull(javaPath);
assertNotNull(cppPath);
}


@Test
public void printlnTest() {
Expand Down
Loading
Loading