[refactor](fe) Remove bilingual descriptions from variable annotations - #66342
Merged
Conversation
### What problem does this PR solve?
Issue Number: N/A
Problem Summary: Session and global variable annotations currently store both Chinese and English descriptions as a two-element array. The Chinese description is unused and the array shape makes callers cumbersome. This change keeps only the English description, updates the VarAttr annotation type, and adjusts the affected unit tests.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- `./run-fe-ut.sh --run org.apache.doris.qe.SessionVariablesTest`
- Behavior changed: No
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
### What problem does this PR solve?
Issue Number: N/A
Problem Summary: Config annotations currently store bilingual descriptions as a two-element array. The Chinese description is unused, and the array shape makes callers cumbersome. This change keeps only the English description, updates the ConfField annotation type, and adds a unit test asserting config descriptions do not contain Chinese.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- `./run-fe-ut.sh --run org.apache.doris.common.ConfigTest`
- Behavior changed: No
- Does this need documentation: No
morningman
previously approved these changes
Aug 5, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
### What problem does this PR solve?
Issue Number: N/A
Problem Summary: After merging master, the branch kept one malformed @ConfField annotation and one remaining VarAttr description array. The malformed annotation made the FE CheckStyle job fail to parse Config.java, and the array form no longer matches the single-string description type. This change repairs the merged syntax, removes the leftover Chinese description, and cleans the related trailing whitespace.
### Release note
None
### Check List (For Author)
- Test: Manual test
- `cd fe && mvn clean checkstyle:check`
- Behavior changed: No
- Does this need documentation: No
github-actions
Bot
removed
the
approved
Contributor
Author
|
run buildall |
1 similar comment
Contributor
|
run buildall |
Contributor
Author
|
run feut |
Contributor
Author
|
run performance |
1 similar comment
Contributor
Author
|
run performance |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run performance |
morningman
approved these changes
Aug 6, 2026
4 tasks
morningman
added a commit
that referenced
this pull request
Aug 6, 2026
…-job config (#66541) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #66342, #66238 Problem Summary: master does not compile. `fe-common` fails at ``` Config.java:[1177,65] annotation value not of an allowable type ``` #66342 retyped `ConfigBase.ConfField.description()` from `String[]` to `String` and rewrote all 419 call sites accordingly. #66238 landed shortly after with ```java @ConfField(mutable = true, masterOnly = true, description = { "Minimum interval in seconds between snapshot offset persistence operations"}) public static int streaming_job_snapshot_offset_persist_interval_sec = 300; ``` written against the older `String[]` signature. The two changes are textually disjoint, so git merges them without a conflict and neither pull request could see the other — each was green on its own base. The seven further errors reported in the same module are secondary. The bad annotation value aborts the annotation-processing round, so lombok never contributes its generated members, and `@Slf4j`'s `log` plus `@AllArgsConstructor`/`@Data`'s constructors go missing: ``` DiskUtils.java:[70,13] cannot find symbol JobBaseConfig ... constructor cannot be applied to given types AbstractSourceSplit ... constructor cannot be applied to given types ``` All seven disappear once the annotation value is fixed; nothing else in the tree needed a change. This is the only remaining array-form description under `fe/` (`grep -rnE 'description\s*=\s*\{'`), and the wrapped-argument layout matches the neighbouring long descriptions such as `max_create_table_timeout_second`. `ConfigTest.testConfFieldDescriptionsAreEnglishStrings`, the guard #66342 added, reflects over the annotation at runtime, so it cannot catch a compile-time signature mismatch; it passes here because the text is already English. Verified on a clean checkout of master `4e3c1b84dd5`: - reproduced the failure before the change, and confirmed all eight errors are gone after it - full FE reactor `mvn test-compile` (checkstyle included): **74/74 modules SUCCESS** - `fe-common` module tests: **157 tests, 0 failures, 0 skipped**, including `ConfigTest.testConfFieldDescriptionsAreEnglishStrings` - the tests both colliding PRs added — `StreamingInsertJobOffsetPersistenceTest`, `JdbcSourceOffsetProviderOffsetTest`, `SessionVariablesTest`: **39 tests, 0 failures, 0 skipped**
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 17, 2026
apache#66342) ### What problem does this PR solve? Issue Number: N/A Problem Summary: Session and global variable annotations currently store both Chinese and English descriptions as a two-element array. The Chinese description is unused and the array shape makes callers cumbersome. This change keeps only the English description, updates the VarAttr annotation type, and adjusts the affected unit tests. ### Release note None ### Check List (For Author) - Test: Unit Test - `./run-fe-ut.sh --run org.apache.doris.qe.SessionVariablesTest` - Behavior changed: No - Does this need documentation: No
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 17, 2026
…-job config (apache#66541) ### What problem does this PR solve? Issue Number: close #xxx Related PR: apache#66342, apache#66238 Problem Summary: master does not compile. `fe-common` fails at ``` Config.java:[1177,65] annotation value not of an allowable type ``` apache#66342 retyped `ConfigBase.ConfField.description()` from `String[]` to `String` and rewrote all 419 call sites accordingly. apache#66238 landed shortly after with ```java @ConfField(mutable = true, masterOnly = true, description = { "Minimum interval in seconds between snapshot offset persistence operations"}) public static int streaming_job_snapshot_offset_persist_interval_sec = 300; ``` written against the older `String[]` signature. The two changes are textually disjoint, so git merges them without a conflict and neither pull request could see the other — each was green on its own base. The seven further errors reported in the same module are secondary. The bad annotation value aborts the annotation-processing round, so lombok never contributes its generated members, and `@Slf4j`'s `log` plus `@AllArgsConstructor`/`@Data`'s constructors go missing: ``` DiskUtils.java:[70,13] cannot find symbol JobBaseConfig ... constructor cannot be applied to given types AbstractSourceSplit ... constructor cannot be applied to given types ``` All seven disappear once the annotation value is fixed; nothing else in the tree needed a change. This is the only remaining array-form description under `fe/` (`grep -rnE 'description\s*=\s*\{'`), and the wrapped-argument layout matches the neighbouring long descriptions such as `max_create_table_timeout_second`. `ConfigTest.testConfFieldDescriptionsAreEnglishStrings`, the guard apache#66342 added, reflects over the annotation at runtime, so it cannot catch a compile-time signature mismatch; it passes here because the text is already English. Verified on a clean checkout of master `4e3c1b84dd5`: - reproduced the failure before the change, and confirmed all eight errors are gone after it - full FE reactor `mvn test-compile` (checkstyle included): **74/74 modules SUCCESS** - `fe-common` module tests: **157 tests, 0 failures, 0 skipped**, including `ConfigTest.testConfFieldDescriptionsAreEnglishStrings` - the tests both colliding PRs added — `StreamingInsertJobOffsetPersistenceTest`, `JdbcSourceOffsetProviderOffsetTest`, `SessionVariablesTest`: **39 tests, 0 failures, 0 skipped**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Problem Summary: Session and global variable annotations currently store both Chinese and English descriptions as a two-element array. The Chinese description is unused and the array shape makes callers cumbersome. This change keeps only the English description, updates the VarAttr annotation type, and adjusts the affected unit tests.
Release note
None
Check List (For Author)
./run-fe-ut.sh --run org.apache.doris.qe.SessionVariablesTest