Skip to content

feat: add java.sql.Date converters (#1017) - #1079

Open
Anubyss-mihail wants to merge 4 commits into
apache:mainfrom
Anubyss-mihail:feat-sql-date-converters-1017
Open

feat: add java.sql.Date converters (#1017)#1079
Anubyss-mihail wants to merge 4 commits into
apache:mainfrom
Anubyss-mihail:feat-sql-date-converters-1017

Conversation

@Anubyss-mihail

Copy link
Copy Markdown

Purpose of the pull request

Related: #1017

Add support for java.sql.Date conversion.

What's changed?

  • Added converters for DATE, NUMBER, and STRING cell types.
  • Registered the new converters in DefaultConverterLoader.
  • Added unit tests for the new converters.

Checklist

@Anubyss-mihail
Anubyss-mihail force-pushed the feat-sql-date-converters-1017 branch 4 times, most recently from d4fe0d9 to 2e206e3 Compare September 9, 2026 16:05
@Anubyss-mihail
Anubyss-mihail force-pushed the feat-sql-date-converters-1017 branch from 2e206e3 to 998247f Compare September 10, 2026 15:59
@Anubyss-mihail
Anubyss-mihail force-pushed the feat-sql-date-converters-1017 branch from 998247f to 6c62e2a Compare September 11, 2026 07:53
@bengbengbalabalabeng

Copy link
Copy Markdown
Contributor

The conversion logic of SqlDateDateConverter and the date offset logic of use1904Windowing belong to two independent paths, and both affect the final date parsing result. Therefore, both scenarios need to be covered by tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants