refactor: split ClassUtils into cache resolvers - #1099
Draft
nkuprins wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT
Closed: #989
Purpose of the pull request
As title
What's changed?
declaredFieldsand its helpers) into a package-privateSheetHeadFieldResolver.declaredExcelContentPropertyand its helpers) into a package-privateSheetContentPropertyResolver.MetadataCacheStrategyperCacheLocationEnumconstant (InMemoryCache,ThreadLocalCache,NoOpCache), selected throughMetadataCaches, which owns the caches for one kind of metadata and picks the tier from theConfigurationHolder.CacheLocationEnumis now referenced in one class instead of three switches.ClassUtilskeepsgetAllInterfaces, both key classes, and every public entry point, delegating to the resolvers.FIELD_CACHE,CLASS_CONTENT_CACHEandCONTENT_CACHEin favour ofgetFieldCache()/getClassContentCache()/getContentCache()(immutable views) and a newremoveInMemoryCache(). The fields still alias the same live, mutable maps, so downstream reads and writes behave exactly as today - only a deprecation warning is added.Checklist