FINERACT-2455: verify delinquency pause works as expected - #6269
Merged
adamsaghy merged 2 commits intoAug 24, 2026
Merged
Conversation
MarianaDmytrivBinariks
force-pushed
the
FINERACT-2455/wc-delinquency-pause-overlap-validation
branch
from
August 20, 2026 13:43
27229c7 to
761ccca
Compare
oleksii-novikov-onix
approved these changes
Aug 21, 2026
galovics
approved these changes
Aug 21, 2026
galovics
left a comment
Contributor
There was a problem hiding this comment.
Confirmed genuinely test-only - two files, both under test sources, no production code touched. Cross-checked the new expectations against the actual validator/overlap logic (WorkingCapitalLoanPausePeriodUtils.inclusivePausePeriodsOverlap, WorkingCapitalLoanDelinquencyActionParseAndValidator.validateNoOverlap) and they're correct - inclusive-boundary cases, resume-effective-end handling, all line up with what the code actually does.
A few things worth tightening before this leaves draft:
- One of the new close steps in the feature file uses a hardcoded date (
25 February 2026) instead of the current business date at that point in the scenario (15 March 2026) - it passes today only because the overpay-vs-accrual gap happens to be zero, but it's a latent flake if WC accrual/backdating rules tighten. - UC6.4 adds a backdated pause on top of an existing one but only re-asserts the delinquency action rows, not the resulting schedule shift - which is the actual pause-date math this PR is meant to verify. UC6.3 has the same gap.
- A chunk of the added lines just append a "close the loan" step to unrelated pause scenarios with no pause-specific assertion afterward - if pause-vs-closure interaction is the goal, a couple of dedicated scenarios would be clearer than a blanket append.
- One test provisions two loans in a single method (
testPauseAfterResumeRespectsEffectiveEndBoundary) - if the first assertion fails we don't learn anything about the second. Worth splitting into two tests.
None of this is blocking - the PR is what it says it is (test coverage, no behavior change) and the new assertions are correct.
Recommendation: APPROVE
adamsaghy
marked this pull request as ready for review
August 24, 2026 09:58
adamsaghy
deleted the
FINERACT-2455/wc-delinquency-pause-overlap-validation
branch
August 24, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.