Skip to content

[FLINK-40633][s3] Allow overriding the Maven executable in download-crt-jars.sh - #29162

Open
gaborgsomogyi wants to merge 1 commit into
apache:masterfrom
gaborgsomogyi:FLINK-40633
Open

[FLINK-40633][s3] Allow overriding the Maven executable in download-crt-jars.sh#29162
gaborgsomogyi wants to merge 1 commit into
apache:masterfrom
gaborgsomogyi:FLINK-40633

Conversation

@gaborgsomogyi

Copy link
Copy Markdown
Contributor

What is the purpose of the change

The download-crt-jars.sh helper in flink-s3-fs-native hardcodes the mvn binary name, requiring plain Maven to be present on PATH. This fails in environments where only a Maven wrapper (or a differently named Maven executable) is available. This pull request adds an MVN environment variable override so the script can invoke any Maven executable, following the same MVN=${MVN:-mvn} convention already used in tools/releasing/*.sh.

Brief change log

  • Introduced an MVN environment variable (defaulting to mvn) in download-crt-jars.sh
  • Replaced the hardcoded mvn invocations with "${MVN}"
  • Updated the script's PATH check and documentation comments accordingly

Verifying this change

Manually tested.
This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Claude code

@flinkbot

flinkbot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Samrat002 Samrat002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants