[FLINK-40633][s3] Allow overriding the Maven executable in download-crt-jars.sh - #29162
Open
gaborgsomogyi wants to merge 1 commit into
Open
[FLINK-40633][s3] Allow overriding the Maven executable in download-crt-jars.sh#29162gaborgsomogyi wants to merge 1 commit into
gaborgsomogyi wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The
download-crt-jars.shhelper inflink-s3-fs-nativehardcodes themvnbinary name, requiring plain Maven to be present onPATH. This fails in environments where only a Maven wrapper (or a differently named Maven executable) is available. This pull request adds anMVNenvironment variable override so the script can invoke any Maven executable, following the sameMVN=${MVN:-mvn}convention already used intools/releasing/*.sh.Brief change log
MVNenvironment variable (defaulting tomvn) indownload-crt-jars.shmvninvocations with"${MVN}"Verifying this change
Manually tested.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Claude code