Skip to content

GROOVY-12386: groovy-json: keep System.Logger out of internal static … - #2908

Merged
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy12386
Sep 9, 2026
Merged

paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy12386

Conversation

@paulk-asert

Copy link
Copy Markdown
Contributor

…initialisers

@codecov-commenter

codecov-commenter commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.1810%. Comparing base (17b99a8) to head (4443e2d).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...va/org/apache/groovy/json/internal/Exceptions.java 33.3333% 5 Missing and 1 partial ⚠️
...main/java/org/apache/groovy/json/internal/Sys.java 33.3333% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2908        +/-   ##
==================================================
- Coverage     71.1943%   71.1810%   -0.0133%     
+ Complexity      37632      37620        -12     
==================================================
  Files            1581       1581                
  Lines          136251     136261        +10     
  Branches        25311      25313         +2     
==================================================
- Hits            97003      96992        -11     
- Misses          30511      30522        +11     
- Partials         8737       8747        +10     
Files with missing lines Coverage Δ
...main/java/org/apache/groovy/json/internal/Sys.java 35.2941% <33.3333%> (-1.3726%) ⬇️
...va/org/apache/groovy/json/internal/Exceptions.java 88.7324% <33.3333%> (-2.0368%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paulk-asert
paulk-asert requested a lite review from Copilot September 9, 2026 11:00

This comment was marked as outdated.

@testlens-app

testlens-app Bot commented Sep 9, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 4443e2d
▶️ Tests: 117685 executed
⚪️ Checks: 33/33 completed


Learn more about TestLens at testlens.app/docs.

@paulk-asert
paulk-asert merged commit 9506a1d into apache:master Sep 9, 2026
34 checks passed
@paulk-asert
paulk-asert deleted the groovy12386 branch September 9, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants