Skip to content

GROOVY-12391: grooid jar: java.beans.Transient is rewritten to a clas… - #2913

Merged
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy12391
Sep 9, 2026
Merged

GROOVY-12391: grooid jar: java.beans.Transient is rewritten to a clas…#2913
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy12391

Conversation

@paulk-asert

Copy link
Copy Markdown
Contributor

…s openbeans never had

@codecov-commenter

codecov-commenter commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.1878%. Comparing base (17b99a8) to head (6ebb625).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2913        +/-   ##
==================================================
- Coverage     71.1943%   71.1878%   -0.0065%     
+ Complexity      37632      37626         -6     
==================================================
  Files            1581       1581                
  Lines          136251     136255         +4     
  Branches        25311      25311                
==================================================
- Hits            97003      96997         -6     
- Misses          30511      30517         +6     
- Partials         8737       8741         +4     

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paulk-asert
paulk-asert requested a lite review from Copilot September 9, 2026 12:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Adds support for excluding specific classes from relocation during grooid jar repackaging to avoid rewriting java.beans.Transient to a non-existent openbeans equivalent (GROOVY-12391), and adds a build-time verification to enforce the constraint.

Changes:

  • Introduces a relocationExcludes input to RepackageJarTask and wires it through GroovyLibraryExtension.
  • Adds a relocation exclusion for java.beans.Transient when repackaging openbeans.
  • Adds a grooidJar post-build check to assert the produced jar still references java.beans.Transient.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
build.gradle Adds relocation exclusion for java.beans.Transient and validates the resulting jar contains the expected reference.
build-logic/src/main/groovy/org/apache/groovy/gradle/RepackageJarTask.groovy Adds relocationExcludes and applies per-pattern exclude rules during relocation.
build-logic/src/main/groovy/org/apache/groovy/gradle/GroovyLibraryExtension.groovy Extends the grooid repackaging API to pass relocation exclusions to the underlying task.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +236 to 241
List<String> untouched = relocationExcludes[pattern] ?: []
boolean skipStrings = shouldSkipStringConstants(prefix)
relocate(prefix, destination) { relocator ->
if (skipStrings) relocator.skipStringConstants = true
untouched.each { relocator.exclude(it) }
}
@testlens-app

testlens-app Bot commented Sep 9, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 6ebb625
▶️ Tests: 112719 executed
⚪️ Checks: 32/32 completed


Learn more about TestLens at testlens.app/docs.

@paulk-asert
paulk-asert merged commit a2fa153 into apache:master Sep 9, 2026
32 of 33 checks passed
@paulk-asert
paulk-asert deleted the groovy12391 branch September 9, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants