Skip to content

HBASE-30382: Update zstd-jni to 1.5.7-15 (branch-2.6) - #8655

Open
arvindKandpal-ksolves wants to merge 1 commit into
apache:branch-2.6from
arvindKandpal-ksolves:HBASE-30382-branch-2.6
Open

arvindKandpal-ksolves wants to merge 1 commit into
apache:branch-2.6from
arvindKandpal-ksolves:HBASE-30382-branch-2.6

Conversation

@arvindKandpal-ksolves

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Bumps zstd-jni from 1.5.7-2 to 1.5.7-15 in pom.xml (branch-2.6).

Why are the changes needed?

zstd-jni versions prior to 1.5.7-14 contain vulnerable code addressed by:

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Ran the full zstd-jni compression test suite before and after the bump:
TestWALCompressionZstd, TestZstdCodec, TestHFileCompressionZstd,
TestZstdDictionary, TestZstdDictionarySplitMerge, TestZstdByteBuffDecompressor.

Baseline (1.5.7-2): 15 tests run, 0 failures, 0 errors
After bump (1.5.7-15): 15 tests run, 0 failures, 0 errors

Verified via mvn dependency:tree that the resolved artifact is
com.github.luben:zstd-jni:jar:1.5.7-15.

Note: on branch-2.6, built with -Dhadoop.profile=3.0 (required for JDK11+).

@arvindKandpal-ksolves

Copy link
Copy Markdown
Contributor Author

I ran all failing tests locally on this branch across the matching JDK/Hadoop combos:

arvindksi274@KLP2757:~/Opensource-works/hbase$ mvn -Dhadoop.profile=3.0 -pl hbase-server -am clean install -DskipTests 2>&1 | tail -20
[INFO] Apache HBase - Common .............................. SUCCESS [ 15.023 s]
[INFO] Apache HBase - Metrics API ......................... SUCCESS [  2.671 s]
[INFO] Apache HBase - Hadoop Compatibility ................ SUCCESS [  2.904 s]
[INFO] Apache HBase - Metrics Implementation .............. SUCCESS [  2.124 s]
[INFO] Apache HBase - Hadoop Two Compatibility ............ SUCCESS [  4.743 s]
[INFO] Apache HBase - Protocol ............................ SUCCESS [  9.503 s]
[INFO] Apache HBase - Client .............................. SUCCESS [ 12.165 s]
[INFO] Apache HBase - Zookeeper ........................... SUCCESS [  3.126 s]
[INFO] Apache HBase - Replication ......................... SUCCESS [  2.442 s]
[INFO] Apache HBase - Resource Bundle ..................... SUCCESS [  0.201 s]
[INFO] Apache HBase - HTTP ................................ SUCCESS [  5.832 s]
[INFO] Apache HBase - Asynchronous FileSystem ............. SUCCESS [  4.900 s]
[INFO] Apache HBase - Procedure ........................... SUCCESS [  3.209 s]
[INFO] Apache HBase - Server .............................. SUCCESS [ 54.130 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:48 min
[INFO] Finished at: 2026-09-17T10:41:46+05:30
[INFO] ------------------------------------------------------------------------

arvindksi274@KLP2757:~/Opensource-works/hbase$ mvn -Dhadoop.profile=3.0 -pl hbase-server test -Dtest=TestSnapshotProcedureRSCrashes#testRegionServerCrashWhileVerifyingSnapshot -DfailIfNoTests=false 2>&1 | grep -E "Tests run|FAIL|ERROR|BUILD"
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 86.31 s -- in org.apache.hadoop.hbase.master.procedure.TestSnapshotProcedureRSCrashes
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] BUILD SUCCESS

arvindksi274@KLP2757:~/Opensource-works/hbase$ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
export PATH=$JAVA_HOME/bin:$PATH
java -version
mvn clean -q
openjdk version "1.8.0_502"
OpenJDK Runtime Environment (build 1.8.0_502-8u502-ga~us1-0ubuntu1~24.04-b07)
OpenJDK 64-Bit Server VM (build 25.502-b07, mixed mode)

arvindksi274@KLP2757:~/Opensource-works/hbase$ mvn -pl hbase-server -am clean install -DskipTests 2>&1 | tail -20
[INFO] Apache HBase - Common .............................. SUCCESS [ 21.632 s]
[INFO] Apache HBase - Metrics API ......................... SUCCESS [  1.490 s]
[INFO] Apache HBase - Hadoop Compatibility ................ SUCCESS [  2.242 s]
[INFO] Apache HBase - Metrics Implementation .............. SUCCESS [  1.608 s]
[INFO] Apache HBase - Hadoop Two Compatibility ............ SUCCESS [  4.604 s]
[INFO] Apache HBase - Protocol ............................ SUCCESS [  7.398 s]
[INFO] Apache HBase - Client .............................. SUCCESS [ 10.707 s]
[INFO] Apache HBase - Zookeeper ........................... SUCCESS [  2.700 s]
[INFO] Apache HBase - Replication ......................... SUCCESS [  1.803 s]
[INFO] Apache HBase - Resource Bundle ..................... SUCCESS [  0.188 s]
[INFO] Apache HBase - HTTP ................................ SUCCESS [ 23.313 s]
[INFO] Apache HBase - Asynchronous FileSystem ............. SUCCESS [  4.105 s]
[INFO] Apache HBase - Procedure ........................... SUCCESS [  2.461 s]
[INFO] Apache HBase - Server .............................. SUCCESS [ 37.714 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:35 min
[INFO] Finished at: 2026-09-17T10:48:01+05:30
[INFO] ------------------------------------------------------------------------

arvindksi274@KLP2757:~/Opensource-works/hbase$ mvn -pl hbase-server test -Dtest=TestFromClientSide3#testMultiRowMutations,TestEditsBehindDroppedTableTiming#testEditsBehindDroppedTableTiming,TestCanaryTool#testWebUI,TestClientScannerTimeouts -DfailIfNoTests=false 2>&1 | grep -E "Tests run|FAIL|ERROR|BUILD"
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 24.44 s <<< FAILURE! -- in org.apache.hadoop.hbase.tool.TestCanaryTool
[ERROR] org.apache.hadoop.hbase.tool.TestCanaryTool.testWebUI -- Time elapsed: 24.17 s <<< ERROR!
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 114.6 s -- in org.apache.hadoop.hbase.client.TestFromClientSide3
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 111.6 s -- in org.apache.hadoop.hbase.replication.TestEditsBehindDroppedTableTiming
[INFO] Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 280.6 s -- in org.apache.hadoop.hbase.client.TestClientScannerTimeouts
[ERROR] Errors: 
[ERROR]   TestCanaryTool.testWebUI:461->getPageContent:581 IllegalState Could not get Canary status page.
[ERROR] Tests run: 35, Failures: 0, Errors: 1, Skipped: 0
[INFO] BUILD FAILURE
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.3:test (default-test) on project hbase-server: 
[ERROR] 
[ERROR] See /home/arvindksi274/Opensource-works/hbase/hbase-server/target/surefire-reports for the individual test results.
[ERROR] See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

arvindksi274@KLP2757:~/Opensource-works/hbase$ mvn -pl hbase-server test -Dtest=TestCanaryTool#testWebUI -DfailIfNoTests=false 2>&1 | grep -E "Tests run|FAIL|ERROR|BUILD"
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 17.03 s <<< FAILURE! -- in org.apache.hadoop.hbase.tool.TestCanaryTool
[ERROR] org.apache.hadoop.hbase.tool.TestCanaryTool.testWebUI -- Time elapsed: 16.91 s <<< ERROR!
[ERROR] Errors: 
[ERROR]   TestCanaryTool.testWebUI:461->getPageContent:581 IllegalState Could not get Canary status page.
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
[INFO] BUILD FAILURE
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.3:test (default-test) on project hbase-server: 
[ERROR] 
[ERROR] See /home/arvindksi274/Opensource-works/hbase/hbase-server/target/surefire-reports for the individual test results.
[ERROR] See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

For TestCanaryTool#testWebUI, I checked the code directly — it's a pure HTTP fetch/retry against an embedded Jetty status server with no reference to zstd/compress anywhere in TestCanaryTool.java or CanaryTool.java. The failure
is a timeout on the retry loop (likely environment startup speed), not a functional regression. CI already classifies this test as "Flakes."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant