HBASE-30382: Update zstd-jni to 1.5.7-15 (branch-2.5) - #8656
Open
arvindKandpal-ksolves wants to merge 1 commit into
Open
arvindKandpal-ksolves wants to merge 1 commit into
arvindKandpal-ksolves wants to merge 1 commit into
Conversation
Contributor
Author
|
Verified locally on branch-2.5, JDK 17.0.20, Hadoop3 profile (-Dhadoop.profile=3.0), matching the "Yetus JDK17 Hadoop3 Unit Check / medium" failing job. With zstd-jni 1.5.7-15 (this PR): With zstd-jni 1.5.7-2 (pristine upstream/branch-2.5, pom.xml reverted): Same failure, identical assertion, with and without the zstd-jni bump — confirms this is a pre-existing issue on branch-2.5, unrelated to this PR. Also confirmed no reference to zstd/compression in either test file or the shared test base class. |
Contributor
Author
|
Verified locally on branch-2.5, JDK 11.0.32, Hadoop3 profile (-Dhadoop.profile=3.0), matching "Yetus JDK11 Hadoop3 Unit Check / medium". TestWALCompressionLzma passes. TestBufferedMutator#testMultiThread and TestBasicWALEntryStreamFSHLog#testCleanClosedWALs fail — confirmed pre-existing by reverting pom.xml to pristine zstd-jni 1.5.7-2 and reproducing the same failures. With zstd-jni 1.5.7-15: With zstd-jni 1.5.7-2 (pristine): |
Contributor
Author
|
Verified locally on branch-2.5, JDK 1.8.0_502, Hadoop2 (default profile), matching "Yetus JDK8 Hadoop2 Unit Check / medium". TestWALCompressionLzma, TestMetaCache, TestMasterRegionFlush, TestBindExceptionHandling: all pass. TestBasicWALEntryStreamAsyncFSWAL/FSHLog#testCleanClosedWALs: fail identically with and without the zstd-jni bump (reverted pom.xml to pristine 1.5.7-2 and reproduced) — pre-existing issue. TestBufferedMutator#testMultiThread: failed once with the bump, passed on rerun without it and again passed with try — consistent with CI's own "Flakes" classification (timing-sensitive, not deterministic either way). see here : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bumps zstd-jni from 1.5.7-2 to 1.5.7-15 in pom.xml (branch-2.5).
Why are the changes needed?
zstd-jni versions prior to 1.5.7-14 contain vulnerable code addressed by:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran the full zstd-jni compression test suite before and after the bump:
TestWALCompressionZstd, TestZstdCodec, TestHFileCompressionZstd,
TestZstdDictionary, TestZstdDictionarySplitMerge, TestZstdByteBuffDecompressor.
Baseline (1.5.7-2): 15 tests run, 0 failures, 0 errors
After bump (1.5.7-15): 15 tests run, 0 failures, 0 errors
Verified via
mvn dependency:treethat the resolved artifact iscom.github.luben:zstd-jni:jar:1.5.7-15.
Note: built with
-Dhadoop.profile=3.0(required for JDK11+).