HBASE-30391 Reduce array copying on expanding ByteArrayOutputStream - #8660
Open
Huginn-kio wants to merge 1 commit into
Open
Huginn-kio wants to merge 1 commit into
Huginn-kio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-30391
Summary
When
ByteArrayOutputStreamexpands, it copies the entire backing array, including unused capacity. This change limits the copy to the bytes already written.See https://issues.apache.org/jira/browse/HBASE-30391
Root cause
ByteArrayOutputStream.checkSizeAndGrowcopiedbuf.lengthbytes when allocating a larger backing array, although onlyposbytes contain valid stream data.Fix
Copy only
posbytes during expansion. This preserves the stream contents while avoiding copies of unused capacity and reducing heap copy work.Testing
mvn -pl hbase-common -am -DskipTests compilewith JDK 17:BUILD SUCCESS.ByteArrayOutputStream.java:BUILD SUCCESS.InterfaceIsTypeviolations in untouchedhbase-annotationstest interfaces.Compatibility