HBASE-30390 Obtain previous cell value in writer buffer instead of copying in encoding - #8662
Open
Huginn-kio wants to merge 1 commit into
Open
Huginn-kio wants to merge 1 commit into
Huginn-kio wants to merge 1 commit into
Conversation
…pying in encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-30390
Summary
Avoid copying previous cell values during data block encoding.
JIRA: https://issues.apache.org/jira/browse/HBASE-30390
Root cause
EncodingState.beforeShipped()copies the complete previous cell withKeyValueUtil.copyToNewKeyValue().FastDiffDeltaEncoderthen uses that copiedcell for previous-value length and content comparison. This allocates and copies
value bytes even though the encoded value is already in the writer buffer.
Fix
encoding paths.
Testing
JAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -pl hbase-common -am -Dtest=TestFastDiffEncodingState -Dsurefire.failIfNoSpecifiedTests=false -DskipITs testJAVA_HOME=$(/usr/libexec/java_home -v 17) mvn -pl hbase-server -am -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotbugs.skip=true compileapache-rat:checkandspotbugs:checkpassed forhbase-common.The full reactor Checkstyle command is currently blocked by existing
InterfaceIsTypeviolations in thehbase-annotationstest-classificationinterfaces; none of the reported lines are part of this change.
Compatibility