HBASE-28620 Release inflight buffer when replication source terminates - #8663
Open
Huginn-kio wants to merge 1 commit into
Open
Huginn-kio wants to merge 1 commit into
Huginn-kio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-28620
Summary
When a replication source terminates while a WAL entry batch is in flight, its buffer quota can remain accounted indefinitely.
Root cause
ReplicationSourceShipper.shipEditspolls aWALEntryBatchfrom the reader queue. The buffer quota is released after successful shipping throughpostShipEdits; if the worker stops before successful shipping, the batch is no longer in the reader queue and cleanup cannot release its quota.Fix
Testing
git diff --check: passed.Compatibility