HBASE-27878 Fix NPE in balancing rsgroup - #8664
Open
Huginn-kio wants to merge 1 commit into
Open
Huginn-kio wants to merge 1 commit into
Huginn-kio wants to merge 1 commit into
Conversation
Huginn-kio
force-pushed
the
HBASE-27878
branch
from
September 16, 2026 14:34
5ad03a6 to
d6bdd6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-27878
Summary
balance_rsgroupcan fail with a NullPointerException when an assignment has no currentregion server. This change builds the RSGroup balancer input through the common
RegionStates#getAssignmentsForBalancer(...)path.https://issues.apache.org/jira/browse/HBASE-27878
Root cause
RSGroupInfoManagerImpl#getRSGroupAssignmentsByTablecopied entries directly fromRegionStates#getRegionAssignments(). A region with a null current location couldtherefore become a null server key, and
RSGroupBasedLoadBalancer#correctAssignmentsthen called
getAddress()on that key.Fix
RegionStates#getAssignmentsForBalancer(...).that are not OPEN or OPENING, while preserving default-group table membership.
disabled-table filtering.
Testing
TestRSGroupsBalance#testGetRSGroupAssignmentsByTablepassed with 1 test run, 0 failures, and0 errors.
TestRSGroupsBalancepassed with 4 tests, 0 failures,and 0 errors.
violations outside this change.
Compatibility