HBASE-30395 Reduce heap buffer copy in decompression - #8665
Open
Huginn-kio wants to merge 1 commit into
Open
Huginn-kio wants to merge 1 commit into
Huginn-kio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-30395
Summary
Avoid an intermediate heap buffer when reading decompressed stream data into an on-heap
ByteBuff.Root cause
The stream fallback in
HFileBlockDefaultDecodingContextusesBlockIOUtils.readFullyWithHeapBuffer, which allocates a temporary heap buffer and copies each read into the destinationByteBuff. This adds an avoidable copy for on-heap destinations.Fix
ByteBuffexposes one.ByteBuffinstances.Compatibility
BlockIOUtilsremains internal.Testing
mvn -pl hbase-server -am -Dtest=TestBlockIOUtils -DfailIfNoTests=false -DskipITs testmvn -pl hbase-common -DskipTests -Dcheckstyle.includes="**/BlockIOUtils.java,**/HFileBlockDefaultDecodingContext.java" checkstyle:checkmvn -pl hbase-server -DskipTests -Dcheckstyle.includes="**/TestBlockIOUtils.java" checkstyle:check