HBASE-30394 Report data block size and count separately in TinyLfuBlockCache - #8666
Open
Huginn-kio wants to merge 1 commit into
Open
Huginn-kio wants to merge 1 commit into
Huginn-kio wants to merge 1 commit into
Conversation
Huginn-kio
force-pushed
the
HBASE-30394
branch
from
September 16, 2026 13:59
c1a11fc to
4e36214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-30394
Summary
TinyLfuBlockCachecurrently exposes aggregate cache size and entry count throughthe data-block-specific
BlockCachemethods. This PR tracks data-block size andcount separately.
See HBASE-30394.
Root cause
getCurrentDataSize()delegates togetCurrentSize()andgetDataBlockCount()delegates togetBlockCount(). Insert and removal pathsdo not maintain data-only counters, so index and metadata blocks are included.
Fix
BlockTypeis data.BlockCachemethods.Testing
git diff --checkJAVA_HOME=/Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home mvn -pl hbase-server -am -DskipTests checkstyle:check -Dcheckstyle.includes='**/io/hfile/TinyLfuBlockCache.java'JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home mvn -pl hbase-server -am -DskipTests -Dcheckstyle.skip -Drat.skip -Dspotbugs.skip compileCompatibility
BlockCachemethods.