HBASE-30389 Fix regionLocation inconsistency when switching master - #8668
Open
Huginn-kio wants to merge 1 commit into
Open
Huginn-kio wants to merge 1 commit into
Huginn-kio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-30389
Summary
Normalize stale region locations while the active master rebuilds assignment state from
hbase:meta after failover.
Root cause
AssignmentManager.RegionMetaLoadingVisitor.visitRegionStatecopies the region server locationfrom hbase:meta into
RegionStateNode, while only states with current-host semantics are added tothe per-server assignment state. A stale location can therefore remain visible for CLOSED or
other non-online regions.
Fix
nullfor states without current-host semantics.lastHostfor locality and recovery decisions.plus a split recovery case.
Testing
mvn --batch-mode -Dtest=TestAssignmentManagerLoadMetaRegionState,TestMasterAbortWhileSplittingRegion -Dsurefire.rerunFailingTestsCount=0 -Dsurefire.parallel.forcedTimeout=900 -Dsurefire.shutdown=kill -DtrimStackTrace=false -DforkCount=0.5C -am -pl ./hbase-server testmvn --batch-mode -pl hbase-server -DskipTests apache-rat:checkCompatibility