HBASE-30397 Correct interrupted log message in ReplicationSourceShipper.clearWALEntryBatch - #8670
Open
Huginn-kio wants to merge 1 commit into
Open
Huginn-kio wants to merge 1 commit into
Huginn-kio wants to merge 1 commit into
Conversation
…er.clearWALEntryBatch
Huginn-kio
force-pushed
the
HBASE-30397
branch
from
September 16, 2026 14:06
9346fa9 to
0e5b655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-30397
Summary
Correct the warning emitted when
ReplicationSourceShipper.clearWALEntryBatchis interrupted while waiting for the shipper and reader threads to stop. This completes the remaining branch of the logging correction tracked in HBASE-30397.Root cause
The
InterruptedExceptionbranch inhbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.javapasses the exception as the final argument to a message with three placeholders. Because the final argument is aThrowable, the final placeholder is not populated as intended. The timeout branch was addressed by HBASE-29698, but this interrupted branch remains.Fix
Throwableargument so SLF4J emits its full stack trace.Testing
git diff --check— pass.Compatibility