Skip to content

HBASE-30397 Correct interrupted log message in ReplicationSourceShipper.clearWALEntryBatch - #8670

Open
Huginn-kio wants to merge 1 commit into
apache:masterfrom
Huginn-kio:HBASE-30397
Open

Huginn-kio wants to merge 1 commit into
apache:masterfrom
Huginn-kio:HBASE-30397

Conversation

@Huginn-kio

@Huginn-kio Huginn-kio commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

HBASE-30397

Summary

Correct the warning emitted when ReplicationSourceShipper.clearWALEntryBatch is interrupted while waiting for the shipper and reader threads to stop. This completes the remaining branch of the logging correction tracked in HBASE-30397.

Root cause

The InterruptedException branch in hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java passes the exception as the final argument to a message with three placeholders. Because the final argument is a Throwable, the final placeholder is not populated as intended. The timeout branch was addressed by HBASE-29698, but this interrupted branch remains.

Fix

  • Remove the final placeholder from the interrupted warning message.
  • Keep the exception as the final Throwable argument so SLF4J emits its full stack trace.

Testing

  • Logging-only change; no test run.
  • git diff --check — pass.
  • Targeted Maven Checkstyle could not run because the available Java runtime is Java 8 while the resolved Checkstyle dependency requires Java 17.

Compatibility

  • Public API impact: none
  • Config impact: none
  • Persisted format impact: none
  • Wire format impact: none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant