HBASE-30393 Clear stale RPC response timestamp when it is completed - #8671
Open
Huginn-kio wants to merge 1 commit into
Open
Huginn-kio wants to merge 1 commit into
Huginn-kio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-30393
Summary
SimpleRpcServercan retain a stale response timestamp after a queued responseis fully written. A later stalled response can then be purged based on the
earlier response's timestamp.
Root cause
SimpleRpcServerResponder.processResponseupdateslastSentTimefor anincomplete response but does not clear it when the response is complete. It also
refreshes the timestamp when a non-blocking write makes no progress.
Fix
lastSentTimewhen the current response is fully written.the write makes progress, or when no timestamp has been recorded yet.
lastSentTimevisible to the responder and purge paths.behavior.
Testing
TestSimpleRpcServerResponder— 3 tests run, 3 failures,0 errors.
TestSimpleRpcServerResponder— 3 tests run, 0 failures,0 errors.
TestSimpleRpcServer,TestSecureSimpleRpcServer,and
TestRpcServerSlowConnectionSetup— 4 tests run, 0 failures, 0 errors.packagebuild — successful.