RFC 9651: Structured Field Values for HTTP by arturobernalg · Pull Request #693 · apache/httpcomponents-core

arturobernalg · 2026-09-03T16:25:16Z

Adds Structured Field Values (RFC 9651) support under org.apache.hc.core5.http.structured: a strict single-pass parser, a canonical serializer, and an immutable value model covering Items, Lists, Dictionaries, parameters and inner lists, and all eight bare-item types (Integer, Decimal, String, Token, Byte Sequence, Boolean, Date, Display String). StructuredFieldHeaders integrates it with message headers. Values are validated and normalized on construction, so serialization is total and round-trips are canonical.

ok2c · 2026-09-12T11:02:17Z

@arturobernalg Very good. Out of curiosity, how much of this change-set was AI generated? It is perfectly fine. It just looks completely different and that makes me think those classes got generated.

Ideally I would like the #hashCode and #equals methods of the new classes to be consistent with the rest of code base. As well argument validation should ideally be done with Args methods. This is not a must. But consistency would be nice.

arturobernalg · 2026-09-13T13:15:02Z

Ideally I would like the #hashCode and #equals methods of the new classes to be consistent with the rest of code base. As well argument validation should ideally be done with Args methods. This is not a must. But consistency would be nice.

@ok2c done. AI assisted always under my revisions.

ok2c · 2026-09-13T17:14:49Z

@ok2c done. AI assisted always under my revisions.

@arturobernalg Very interesting. Did you train it to use our parsing APIs or was that part hand-written?

ok2c

@arturobernalg #hashCode now look good. Almost there.

ok2c · 2026-09-13T17:39:16Z

+     */
+    public static StructuredFieldBareItem ofDecimal(final BigDecimal value) {
+        Args.notNull(value, "Decimal value");
+        if (value.abs().compareTo(DECIMAL_ROUNDING_LIMIT) >= 0) {


@arturobernalg One can use Args#check here

ok2c · 2026-09-13T17:41:08Z

+            }
+            return this.type == StructuredFieldType.BYTE_SEQUENCE
+                    ? Arrays.equals((byte[]) this.value, (byte[]) that.value)
+                    : LangUtils.equals(this.value, that.value);


@arturobernalg Wait. No need to use deprecated methods.

arturobernalg requested a review from ok2c September 3, 2026 16:25

ok2c reviewed Sep 4, 2026

View reviewed changes

Comment thread httpcore5/src/main/java/org/apache/hc/core5/http/structured/StructuredFieldParser.java Outdated

Comment thread httpcore5/src/main/java/org/apache/hc/core5/http/structured/StructuredFieldParser.java Outdated

arturobernalg force-pushed the structured-field-values branch from 59a96a3 to 1f35bb5 Compare September 4, 2026 10:53

arturobernalg requested a review from ok2c September 4, 2026 10:53

ok2c reviewed Sep 4, 2026

View reviewed changes