Skip to content

fix(pd): keep KvClient watches alive after reconnect failures #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
contrueCT wants to merge 2 commits into
base: master
Choose a base branch
from
+883 −95
Open

fix(pd): keep KvClient watches alive after reconnect failures #3157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
772b3a5
fix(pd): keep KvClient watches alive after reconnect failures
contrueCT Aug 15, 2026
3c2f4df
fix(pd): address kv watch review feedback
contrueCT Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions hugegraph-pd/hg-pd-client/src/main/java/org/apache/hugegraph/pd/client/AbstractClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ private String resetStub() {
Exception ex = null;
for (int i = 0; i < proxy.getHostCount(); i++) {
String host = proxy.nextHost();
close();
closeConnections();

channel = ManagedChannelBuilder.forTarget(host).usePlaintext().build();
PDBlockingStub blockingStub =
Expand All @@ -149,7 +149,7 @@ private String resetStub() {
Metapb.Member leader = members.getLeader();
leaderHost = leader.getGrpcUrl();
if (!host.equals(leaderHost)) {
close();
closeConnections();
channel = ManagedChannelBuilder.forTarget(leaderHost).usePlaintext().build();
}
proxy.setBlockingStub(setBlockingParams(createBlockingStub(), config));
Expand Down Expand Up @@ -261,20 +261,26 @@ protected <ReqT, RespT> void streamingCall(MethodDescriptor<ReqT, RespT> method,
proxy.setStub(null);
}
streamingCall(method, request, responseObserver, ++retry);
return;
}
}
throw new PDException(Pdpb.ErrorType.PD_UNREACHABLE_VALUE,
"RPC streaming call failed", e);
}
}

@Override
public void close() {
closeConnections();
}

private void closeConnections() {
closeChannel(channel);
if (stubs != null) {
for (AbstractBlockingStub stub : stubs.values()) {
closeChannel((ManagedChannel) stub.getChannel());
}
}

}

private void closeChannel(ManagedChannel channel) {
Expand Down
Loading
Loading