Skip to content

Fix flaky moto_server fixture by using an OS-assigned ephemeral port #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
puchengy wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −8
Open

Fix flaky moto_server fixture by using an OS-assigned ephemeral port #3759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@

import os
import re
import socket
import string
import time
import uuid
Expand Down Expand Up @@ -2341,14 +2340,14 @@ def fixture_aws_credentials() -> Generator[None, None, None]:


@pytest.fixture(scope="session")
def moto_server() -> "ThreadedMotoServer":
def moto_server() -> Generator["ThreadedMotoServer", None, None]:
from moto.server import ThreadedMotoServer

server = ThreadedMotoServer(ip_address="localhost", port=5001)

# this will throw an exception if the port is already in use
with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
s.bind((server._ip_address, server._port))
# Bind to port 0 so the OS assigns a free ephemeral port. A hardcoded port
# collides when tests run in parallel (e.g. on shared CI agents) or when a
# previous run leaves the port in TIME_WAIT, raising
# "OSError: [Errno 98] Address already in use".
server = ThreadedMotoServer(ip_address="localhost", port=0)

server.start()
yield server
Expand All @@ -2357,7 +2356,8 @@ def moto_server() -> "ThreadedMotoServer":

@pytest.fixture(scope="session")
def moto_endpoint_url(moto_server: "ThreadedMotoServer") -> str:
_url = f"http://{moto_server._ip_address}:{moto_server._port}"
host, port = moto_server.get_host_and_port()
_url = f"http://{host}:{port}"
return _url


Expand Down