IGNITE-29050 Introduce snapshot deletion command by Vladsz83 · Pull Request #13577 · apache/ignite

Vladsz83 · 2026-09-10T22:13:50Z

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

There is a single JIRA ticket related to the pull request.
The web-link to the pull request is attached to the JIRA ticket.
The JIRA ticket has the Patch Available state.
The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

# Conflicts: # modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/IgniteSchema.java

…ommand

github-actions · 2026-09-16T10:32:50Z

Possible compatibility issues. Please, check rolling upgrade cases

This PR modifies protected classes (with Order annotation).
Changes to these classes can break rolling upgrade compatibility.

Affected files:

modules/core/src/main/java/org/apache/ignite/internal/management/snapshot/SnapshotDeleteCommandArg.java
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsSingleMessage.java
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotDeleteProcessResult.java
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotDeleteRequest.java
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotDeleteResponse.java

zstan · 2026-09-17T11:22:11Z

+
+The delete operation is subject to the following limitations:
+
+* The deletion is rejected if any concurrent snapshot operation (create, restore, check, or a delete with the same name) is


if any concurrent - "concurrent_" is sounds like our working term it clear for you and me but for common people you need to re-phrase it like : "The deletion is rejected if any snapshot operation with the same snapshot path\name" smth like this. Concurrent may be treated like JUST one more snapshot operation no matter with this name\path or another.

zstan · 2026-09-17T11:24:54Z

+
+* The deletion is rejected if any concurrent snapshot operation (create, restore, check, or a delete with the same name) is
+  active for the snapshot.
+* The operation is irreversible. It cannot be undone, and the deleted snapshot cannot be restored.


Suggested change

* The operation is irreversible. It cannot be undone, and the deleted snapshot cannot be restored.

* The operation cannot be cancelled. It cannot be undone, and the deleted snapshot cannot be restored.

zstan · 2026-09-17T11:25:19Z

+* The deletion is rejected if any concurrent snapshot operation (create, restore, check, or a delete with the same name) is
+  active for the snapshot.
+* The operation is irreversible. It cannot be undone, and the deleted snapshot cannot be restored.
+* The command prompts for a confirmation before the deletion because the operation is irreversible and cannot be undone.


Suggested change

* The command prompts for a confirmation before the deletion because the operation is irreversible and cannot be undone.

* The command prompts for a confirmation before the deletion.

zstan · 2026-09-17T11:26:54Z

+public class SnapshotDeleteCommand extends AbstractSnapshotCommand<SnapshotDeleteCommandArg, SnapshotDeleteProcessResult> {
+    /** {@inheritDoc} */
+    @Override public String description() {
+        return "Deletes snapshot and all its increments from all the online server nodes";


fix for : "increments"

zstan · 2026-09-17T11:30:44Z

+        if (!F.isEmpty(res.uncompletedNodes())) {
+            found = true;
+
+            printer.accept("WARNING, the following nodes found snapshot data but might not remove it completely "


Suggested change

printer.accept("WARNING, the following nodes found snapshot data but might not remove it completely "

printer.accept("WARNING: the following nodes found snapshot data but might not remove it completely"

``` also i can\t fount the relative test, plz append it

also : do we need here and else where "." at the end ?

zstan · 2026-09-17T13:30:14Z

+
+    /** */
+    @Test
+    public void testConcurrentUnfinishedRU() throws Exception {


test name - confusing, rename it please, or append java doc

zstan · 2026-09-17T13:35:56Z

+
+    /** Nodes which found snapshot data and completely removed it. */
+    @Order(0)
+    @Nullable Collection<UUID> completedNodes;


probably it`s better to initialize with empty collections all of them ? And aslo initialization constructor code references ?

zstan · 2026-09-17T13:41:49Z

+
+    /** */
+    @Test
+    public void testNodeNotSupportingSnapshotDeleteFeature() throws Exception {


test name need to be changed, as I can see - this test is about unsupported ver of thick client?

zstan · 2026-09-17T13:42:21Z

+        for (int i = 0; i < ALL_GRIDS; i++) {
+            assertFalse(ru(grid(i)).isVersionUpgradeEnabled());
+
+            assertFalse(F.isEmpty(snp(i).deleteSnapshot(SNP_NAME, null).get().completedNodes));


Suggested change

for (int i = 0; i < ALL_GRIDS; i++) {

assertFalse(ru(grid(i)).isVersionUpgradeEnabled());

assertFalse(F.isEmpty(snp(i).deleteSnapshot(SNP_NAME, null).get().completedNodes));

@Nullable Collection<UUID> compNodes = null;

for (int i = 0; i < ALL_GRIDS; i++) {

assertFalse(ru(grid(i)).isVersionUpgradeEnabled());

if (compNodes == null)

compNodes = snp(i).deleteSnapshot(SNP_NAME, null).get().completedNodes();

else

assertEqualsCollectionsIgnoringOrder(compNodes, snp(i).deleteSnapshot(SNP_NAME, null).get().completedNodes());

zstan · 2026-09-17T13:45:14Z

+        int partsCnt = 32;
+        int keysCnt = partsCnt * 10;
+
+        grid(gridIdx).createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME)
+            .setCacheMode(CacheMode.REPLICATED)
+            .setBackups(1)
+            .setAffinity(new RendezvousAffinityFunction().setPartitions(32))
+            .setWriteSynchronizationMode(CacheWriteSynchronizationMode.FULL_SYNC)
+            .setAtomicityMode(CacheAtomicityMode.ATOMIC));


Suggested change

int partsCnt = 32;

int keysCnt = partsCnt * 10;

grid(gridIdx).createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME)

.setCacheMode(CacheMode.REPLICATED)

.setBackups(1)

.setAffinity(new RendezvousAffinityFunction().setPartitions(32))

.setWriteSynchronizationMode(CacheWriteSynchronizationMode.FULL_SYNC)

.setAtomicityMode(CacheAtomicityMode.ATOMIC));

int partsCnt = 5;

int keysCnt = partsCnt * 10;

grid(gridIdx).createCache(new CacheConfiguration<>(DEFAULT_CACHE_NAME)

.setCacheMode(CacheMode.REPLICATED)

.setAffinity(new RendezvousAffinityFunction().setPartitions(partsCnt))

.setAtomicityMode(CacheAtomicityMode.ATOMIC));

a bit speed up

Vladsz83 and others added 20 commits September 7, 2026 19:39

neuroslop

eb6273c

IGNITE-29037 Refactored Message Factory usage in TCP Discovery implem…

d9aa470

…entations (apache#13551)

raw

7042aec

raw

682a21c

Merge branch 'master' into support-snapshot-lists

bcc72c4

raw

3ab443a

raw

9171c7e

+ snpPath

de68328

better tests

f0996e9

own test

80c7644

Merge branch 'master' into snp-delete

c8d1c25

# Conflicts: # modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/IgniteSchema.java

+ test

fc11a5f

Simplification

8a007e3

+ restore test

97ab26c

+ create test

fbb2cf8

reimpl tests

2ed26ad

better IgniteClusterSnapshotDeleteTest

9b0e5ff

+incr test

b09e0b3

raw

71717c2

+ feature support test

7148da6

github-actions Bot added the compatibility label Sep 10, 2026

Vladsz83 added 9 commits September 11, 2026 01:50

+ IgniteClusterSnapshotDeleteTest

d36c642

fix

9a658df

Merge branch 'master' into Introduce-snapshot-deletion-command

35a4c9d

test fix + doc

d715c66

+ RU test. + many small fixes.

e6aa330

review fixes

4233322

test fix

b11f389

Merge branch 'master' into IGNITE-29050-Introduce-snapshot-deletion-c…

37cb071

…ommand

+ tests

f00d266

Vladsz83 added 8 commits September 14, 2026 22:56

+ tests

57909f4

Merge branch 'master' into Introduce-snapshot-deletion-command

edd86d7

+ delete-deletePath test

7e82295

+ another delete-deletePath tests

ed9cc3a

+ test pf deletion repeat on restarted offline node

bb1dfec

+ stop-node test, fixes

129b090

revert delete cancel flag

4249205

+ RU test

b7c182d

zstan reviewed Sep 17, 2026

View reviewed changes

Navigation Menu

IGNITE-29050 Introduce snapshot deletion command - #13577

IGNITE-29050 Introduce snapshot deletion command#13577
Vladsz83 wants to merge 37 commits into
apache:masterfrom
Vladsz83:Introduce-snapshot-deletion-command

Vladsz83 commented Sep 10, 2026

Uh oh!

github-actions Bot commented Sep 16, 2026

Uh oh!

zstan Sep 17, 2026

Uh oh!

zstan Sep 17, 2026

Uh oh!

zstan Sep 17, 2026

Uh oh!

zstan Sep 17, 2026

Uh oh!

zstan Sep 17, 2026

Uh oh!

zstan Sep 17, 2026

Uh oh!

zstan Sep 17, 2026

Uh oh!

zstan Sep 17, 2026

Uh oh!

zstan Sep 17, 2026

Uh oh!

zstan Sep 17, 2026

Uh oh!

zstan Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		The delete operation is subject to the following limitations:

		* The deletion is rejected if any concurrent snapshot operation (create, restore, check, or a delete with the same name) is

	* The operation is irreversible. It cannot be undone, and the deleted snapshot cannot be restored.
	* The operation cannot be cancelled. It cannot be undone, and the deleted snapshot cannot be restored.

	* The command prompts for a confirmation before the deletion because the operation is irreversible and cannot be undone.
	* The command prompts for a confirmation before the deletion.

	printer.accept("WARNING, the following nodes found snapshot data but might not remove it completely "
	printer.accept("WARNING: the following nodes found snapshot data but might not remove it completely"
	``` also i can\t fount the relative test, plz append it

Conversation

Vladsz83 commented Sep 10, 2026

The Contribution Checklist

Notes

Uh oh!

github-actions Bot commented Sep 16, 2026

Possible compatibility issues. Please, check rolling upgrade cases

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants