Skip to content

Fix WAL roll file test flush wait - #17904

Open
Caideyipi wants to merge 3 commits into
masterfrom
fix-wal-roll-file-test-wait
Open

Fix WAL roll file test flush wait#17904
Caideyipi wants to merge 3 commits into
masterfrom
fix-wal-roll-file-test-wait

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Wait for the WALFlushListener returned by WAL writes instead of polling WAL buffer internal consumed state. Tests: mvn -Ddevelocity.off=true spotless:check -pl iotdb-core/datanode

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.85%. Comparing base (f2dd701) to head (5b8bbd0).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17904      +/-   ##
============================================
+ Coverage     42.71%   42.85%   +0.13%     
  Complexity      343      343              
============================================
  Files          5356     5356              
  Lines        380693   380712      +19     
  Branches      49415    49416       +1     
============================================
+ Hits         162632   163157     +525     
+ Misses       218061   217555     -506     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Caideyipi

Copy link
Copy Markdown
Collaborator Author

Updated this PR onto the latest master (dc47a3b). The reported timeout occurs while polling WALBuffer.isAllWALEntriesConsumed() before the actual waitForNextReady assertion. The test now waits on the WALFlushListener returned by each write, which synchronizes on the completed flush without depending on the buffer's transient internal state. Spotless check passes locally; CI has been re-triggered.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant