HDDS-11355. Remove Flaky tag from testMultiBlockWritesWithIntermittentDnFailures - #11101
Open
shuan1026 wants to merge 1 commit into
Open
HDDS-11355. Remove Flaky tag from testMultiBlockWritesWithIntermittentDnFailures#11101shuan1026 wants to merge 1 commit into
shuan1026 wants to merge 1 commit into
Conversation
…s#testMultiBlockWritesWithIntermittentDnFailures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This removes the
@Flaky("HDDS-11355")annotation fromTestMultiBlockWritesWithDnFailures#testMultiBlockWritesWithIntermittentDnFailures.The test was marked flaky after a single intermittent failure (
StorageContainerException: Unable to find the block with bcsID .... To check whether the underlying race is still present, the test was re-run 700 times against current master:No failures were reproduced, and a review of the commits touching this test since it was flagged found only cosmetic changes (renames, license-header fixes, a mechanical switch to a global JUnit5 timeout) no real fix for a race condition. Given the zero-failure rate over 700 runs and no further failure reports since, this proposes removing the flaky tag rather than leaving the test permanently skipped.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11355
How was this patch tested?
Via
workflow_dispatchon a fork, running the test 700 times on current master with zero failures.