[python] Support custom dataset readers in PaimonLeRobotDataset - #9785
Open
XiaoHongbo-Hope wants to merge 16 commits into
Open
[python] Support custom dataset readers in PaimonLeRobotDataset#9785XiaoHongbo-Hope wants to merge 16 commits into
XiaoHongbo-Hope wants to merge 16 commits into
Conversation
XiaoHongbo-Hope
marked this pull request as ready for review
September 13, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Let
PaimonLeRobotDatasetread logical frames through custom dataset readers.Changes
PaimonDatasetReader: metadata, logical frame schema, validated batched row reads, delta windows, media decoding, and Torch conversion.PaimonLeRobotDataseta Dataset facade overPaimonDatasetReader.PaimonDatasetReaderthrough the same constructor.Custom readers implement
read_indices.schemaenables eager validation;file_iois required only for BLOB or video descriptors. Reader instances must be picklable for DataLoader workers.Relationship to LeRobot
LeRobot
mainselects aBaseDatasetReaderbymeta.storage_format. The reader owns row access, delta windows, media decoding, and returns assembled samples.The
BaseDatasetReadersource docstring explicitly lets subclasses define their own constructors because storage inputs differ.schemaandfile_ioare PyPaimon-specific inputs, not LeRobot parameters.PaimonDatasetReadermirrors the official Reader responsibilities. Once the official contract is available in PyPaimon's supported LeRobot range, it can implementBaseDatasetReaderwithout changing custom row-resolution code.Official references:
BaseDatasetReader,storage_formatreader lookup.Review focus
Is the minimum custom-reader contract (
read_indices, plus optionalschemaandfile_io) sufficient while keeping sample assembly in one Reader?Tests
80 passedinmultimodal_lerobot_test.py.git diff --checkpass.