Skip to content

docs: drop hardcoded test-class counts from the review guides #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukaszlenart merged 1 commit into from
Aug 30, 2026
Merged

docs: drop hardcoded test-class counts from the review guides #1886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/skills/code-review/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,14 @@ Deeper references, when a review needs them:
`org.junit.jupiter` imports. Two styles coexist and a new test must match the
style already in the file it joins:

- **JUnit 3 style** — around 117 classes extend `XWorkTestCase`, which extends
- **JUnit 3 style** — classes extending `XWorkTestCase`, which extends
`junit.framework.TestCase`. Test methods must be named `testXxx()`. A Jupiter
`@Test` annotation added to one of these **silently never runs** — it does not
fail, it is simply not collected. Flag this as blocking whenever you see
`org.junit.jupiter` in a diff.
- **JUnit 4 style** — around 212 classes use `import org.junit.Test`.
- **JUnit 4 style** — classes using `import org.junit.Test`.

Both styles are widespread and neither is being migrated away from.

AssertJ assertions and Mockito mocks are both available and widely used.
Introducing JUnit 5 is a build-infrastructure change that needs its own `WW-`
Expand Down
7 changes: 5 additions & 2 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,13 @@ Run with `mvn test -DskipAssembly`.
**Tests are JUnit 4 — there is no JUnit 5 anywhere in this repo.** `parent/pom.xml` declares
`junit:junit:4.13.2`; there are zero `org.junit.jupiter` imports. Two styles coexist:

- **JUnit 3 style** — ~114 classes extend `XWorkTestCase` (which extends `junit.framework.TestCase`).
- **JUnit 3 style** — classes extending `XWorkTestCase` (which extends `junit.framework.TestCase`).
Methods must be named `testXxx()`. A Jupiter `@Test` annotation added to one of these **silently
never runs** — it does not fail, it is simply not collected.
- **JUnit 4 style** — ~210 classes use `import org.junit.Test`.
- **JUnit 4 style** — classes using `import org.junit.Test`.

Both styles are widespread and neither is being migrated away from; `grep -rl` for either marker
gives the current split.

Before adding a test, open the target file and match the style already there. AssertJ assertions and
Mockito mocks are both available and widely used. Introducing Jupiter is a build-infrastructure change
Expand Down
Loading