WW-5713 Fail closed for legacy Tiles OGNL evaluation - #1890
Open
kuranikaran wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Tiles plugin registers separate
S2:and legacyOGNL:attribute-expression evaluators. The legacy evaluator operates directly against the TilesRequestand does not use the Struts OGNL controls used byS2:.This change keeps
OGNL:registered but makes it fail closed by default. Evaluation throws TilesEvaluationExceptionwith migration guidance and does not parse or evaluate the expression.Applications that temporarily require the existing raw behavior can explicitly set:
The compatibility constant and legacy evaluator are deprecated in Struts 7.4.0 and targeted for removal in Struts 8.0.0. The raw evaluator and its global
OgnlRuntimeTilesRequestproperty-accessor setup are constructed only when legacy mode is explicitly enabled. Legacy mode preserves the existing behavior and emits one startup/container-construction warning.S2:,I18N:, andEL:remain unchanged.Testing
verifylifecycle, including Apache RAT and JAR packagingClassification
This is defense-in-depth hardening. No attacker-controlled expression source or concrete vulnerability impact has been demonstrated, and no security advisory is proposed.
Issue: WW-5713