Skip to content

feat(config): turn the Form View on by default #8528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yangzhang75 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

feat(config): turn the Form View on by default #8528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/config/src/main/resources/gui.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ gui {
timetravel-enabled = ${?GUI_WORKFLOW_WORKSPACE_TIMETRAVEL_ENABLED}

# whether the Form View (a second, form-based view of a workflow) is enabled
form-view-enabled = false
form-view-enabled = true
form-view-enabled = ${?GUI_WORKFLOW_WORKSPACE_FORM_VIEW_ENABLED}

# Whether to connect to local or production shared editing server. Set to true if you have
Expand Down
4 changes: 2 additions & 2 deletions common/config/src/test/scala/org/apache/texera/common/config/GuiConfigSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ class GuiConfigSpec extends AnyFlatSpec with Matchers {
ifUnset("GUI_WORKFLOW_WORKSPACE_TIMETRAVEL_ENABLED")(
GuiConfig.guiWorkflowWorkspaceTimetravelEnabled shouldBe false
)
// Form View ships disabled so merging the feature never turns it on; the final PR flips it.
// Form View is on by default now that the whole feature has landed.
ifUnset("GUI_WORKFLOW_WORKSPACE_FORM_VIEW_ENABLED")(
GuiConfig.guiWorkflowWorkspaceFormViewEnabled shouldBe false
GuiConfig.guiWorkflowWorkspaceFormViewEnabled shouldBe true
)
ifUnset("GUI_WORKFLOW_WORKSPACE_PRODUCTION_SHARED_EDITING_SERVER")(
GuiConfig.guiWorkflowWorkspaceProductionSharedEditingServer shouldBe false
Expand Down
Loading