fix(amber): consolidate retry policies - #8534
Conversation
Backport auto-label reportThis
|
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8534 +/- ##
============================================
- Coverage 95.88% 95.71% -0.17%
- Complexity 459 506 +47
============================================
Files 588 588
Lines 33802 34330 +528
Branches 4217 4337 +120
============================================
+ Hits 32411 32860 +449
- Misses 813 869 +56
- Partials 578 601 +23
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 379 | 0.231 | 25,987/35,637/35,637 us | 🔴 +9.6% / 🔴 +142.6% |
| 🔴 | bs=100 sw=10 sl=64 | 782 | 0.477 | 124,200/157,910/157,910 us | 🔴 +13.4% / 🔴 +58.7% |
| 🔴 | bs=1000 sw=10 sl=64 | 893 | 0.545 | 1,118,187/1,192,136/1,192,136 us | 🔴 +5.4% / 🔴 +25.4% |
Baseline details
Latest main 7190a81 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 379 tuples/sec | 412 tuples/sec | 838.23 tuples/sec | -8.0% | -54.8% |
| bs=10 sw=10 sl=64 | MB/s | 0.231 MB/s | 0.251 MB/s | 0.512 MB/s | -8.0% | -54.8% |
| bs=10 sw=10 sl=64 | p50 | 25,987 us | 23,710 us | 11,878 us | +9.6% | +118.8% |
| bs=10 sw=10 sl=64 | p95 | 35,637 us | 33,733 us | 14,690 us | +5.6% | +142.6% |
| bs=10 sw=10 sl=64 | p99 | 35,637 us | 33,733 us | 18,483 us | +5.6% | +92.8% |
| bs=100 sw=10 sl=64 | throughput | 782 tuples/sec | 814 tuples/sec | 1,095 tuples/sec | -3.9% | -28.6% |
| bs=100 sw=10 sl=64 | MB/s | 0.477 MB/s | 0.497 MB/s | 0.668 MB/s | -4.0% | -28.6% |
| bs=100 sw=10 sl=64 | p50 | 124,200 us | 120,239 us | 92,901 us | +3.3% | +33.7% |
| bs=100 sw=10 sl=64 | p95 | 157,910 us | 139,246 us | 99,480 us | +13.4% | +58.7% |
| bs=100 sw=10 sl=64 | p99 | 157,910 us | 139,246 us | 112,580 us | +13.4% | +40.3% |
| bs=1000 sw=10 sl=64 | throughput | 893 tuples/sec | 908 tuples/sec | 1,126 tuples/sec | -1.7% | -20.7% |
| bs=1000 sw=10 sl=64 | MB/s | 0.545 MB/s | 0.554 MB/s | 0.687 MB/s | -1.6% | -20.7% |
| bs=1000 sw=10 sl=64 | p50 | 1,118,187 us | 1,102,010 us | 912,010 us | +1.5% | +22.6% |
| bs=1000 sw=10 sl=64 | p95 | 1,192,136 us | 1,131,314 us | 950,922 us | +5.4% | +25.4% |
| bs=1000 sw=10 sl=64 | p99 | 1,192,136 us | 1,131,314 us | 983,333 us | +5.4% | +21.2% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,527.84,200,128000,379,0.231,25986.78,35637.46,35637.46
1,100,10,64,20,2557.66,2000,1280000,782,0.477,124200.44,157910.21,157910.21
2,1000,10,64,20,22399.90,20000,12800000,893,0.545,1118187.43,1192135.78,1192135.78|
/request-review CI note: the remaining Amber and file-service failures are the repository-wide MinIO image outage (minio/minio:RELEASE.2025-02-28T09-55-16Z returns HTTP 404). The focused retry-policy suites pass as documented above. |
|
Please specify at least one reviewer: |
What changes were proposed in this PR?
Move the final two blocking retry loops onto
RetryUtil.withBackoffwhile preserving their public contracts.PythonProxyClientWorkflowRuntimeExceptionon failureURLFetchUtilRetryUtilnow supports a delay multiplier and caller-defined terminal exception factory.Any related issues, documentation, discussions?
Closes #7124
How was this PR tested?
The new contract tests failed to compile before the utility/API changes. After the implementation, 17 utility, 8 URL fetcher, and 10 Python client tests pass:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex was used for implementation and verification assistance. I reviewed the final code and test output before submission.