test: isolate joined inheritance routes - #8532
Merged
Merged
Conversation
soyuka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The route-name collision check added in #8502 exposed two globally loaded
Fooresources that generated the same operation name during test application boot.This moves the joined-inheritance fixtures out of the legacy issue-number namespace, gives every fixture operation an explicit unique short name and URI template, and loads the existing
Fooalongside the renamed owner in the focused functional test so the collision remains covered.Tests:
vendor/bin/phpunit tests/Functional/Doctrine/JoinedInheritanceSerializerGroupsTest.php --filter testJoinedInheritanceSubclassGroupsEmbedRelationPHP_CS_FIXER_IGNORE_ENV=1 vendor/bin/php-cs-fixer fix --ansi --show-progress=none --sequentialBroader regression scope is left to CI.