docs: Restructure topic on env vars - #1307
Open
szaganek wants to merge 3 commits into
Open
Conversation
szaganek
added
documentation
| ``` | ||
|
|
||
| Use the following environment variable to point the CLI at a non-production Apify Console, such as a staging deployment or a local instance during development. | ||
| ## CLI environment variables |
Contributor
There was a problem hiding this comment.
I am not sure whatever we need this section as I do not know the use case for our users. Maybe it's only for Apify internal developers, and it should be internal documentation, not public. Cc. @DaveHanns, maybe you know more details.
Contributor
There was a problem hiding this comment.
The repository is public and non-Apifiers can contribute (create PRs), so it is reasonable to have this public.
I would probably put it in the CONTRIBUTING.md tho (https://github.com/apify/apify-cli/blob/master/CONTRIBUTING.md).
patrikbraborec
left a comment
patrikbraborec
left a comment
Contributor
There was a problem hiding this comment.
Looks good, only one point. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The topic structure stopped making sense once we added the new env var.
Closes #1279.