chore: sync PHP client with Apify OpenAPI spec v2-2026-09-10T091137Z - #13
Open
Pijukatel wants to merge 1 commit into
Open
chore: sync PHP client with Apify OpenAPI spec v2-2026-09-10T091137Z#13Pijukatel wants to merge 1 commit into
Pijukatel wants to merge 1 commit into
Conversation
apify-service-account
added
the
tested
apify-service-account
added
the
t-tooling
Pijukatel
added
adhoc
Claude
apify-service-account
added
the
tested
Pijukatel
pushed a commit
that referenced
this pull request
Sep 11, 2026
…dence Addresses an independent review's low-severity finding on PR #13: the existing unit tests only proved a "true" header beating a false option and the absent-header fallback, so a header value of "false" could pass those tests even if headerBool() ignored the header entirely. Add the symmetric case (header "false" overriding a requested desc: true) to actually prove header parsing, not just fallback. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RSRQiKuykuXATHK8g1FDqU
Syncs Version::API_SPEC_VERSION to v2-2026-09-10T091137Z (apify-docs #2965), which documents the X-Apify-Pagination-* response headers on all offset-paginated list endpoints, including the previously-undocumented X-Apify-Pagination-Desc. All collection clients already implemented this ahead of spec except DatasetClient::listItems(), which derived PaginationList::isDesc() from the request option instead of the response header; fixed to read the header (new headerBool() helper), matching the reference JS client's _createPaginationList, with unit and integration coverage for the header-precedence and fallback cases.
Pijukatel
force-pushed
the
claude/vibrant-ramanujan-mwdmsv
branch
from
September 11, 2026 23:54
df83518 to
82aaa6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
Version::API_SPEC_VERSIONtov2-2026-09-10T091137Z(apify-docs#2965), which documentsX-Apify-Pagination-*response headers on all offset-paginated list endpoints, including the previously-undocumentedX-Apify-Pagination-Desc. All collection clients already implemented this correctly ahead of spec, exceptDatasetClient::listItems(), which derivedPaginationList::isDesc()from the request option instead of the response header — fixed to read the header (newheaderBool()helper), matching the reference JS client's_createPaginationList, with unit and integration coverage for the header-precedence and fallback cases.