Set CA_CERT_PATH only when an object storage CA cert is provided - #1325
Merged
Conversation
The path was emitted unconditionally, pointing the platform at /data/credentials/ca.crt even when no CA_CERT_DATA was configured. Charts between v2026.5 and v2026.6 always rendered a ca.crt key in the objstore secret, and Helm cannot drop that key on upgrade, so those installations mount an empty file at that path and every bucket operation fails. Signed-off-by: Arnob kumar saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CA_CERT_PATHwas emitted unconditionally in the platform config, pointing b3 at/data/credentials/ca.crtwhether or notobjstore.s3.CA_CERT_DATAwas ever set.That is harmless when the file is absent, but not when it exists and is empty — which is the case on any installation that passed through charts v2026.5–v2026.6. Commit 88effb3 made
objstore-cred.yamlalways renderca.crt: "", writing an empty key into the secret. 802ccc5 restored thewithguard, so the key left the manifest, but Helm cannot delete it: the secret's storedlast-applied-configurationis from v2026.4.30 and never containedca.crt, so it was never in the removal set. The empty key is orphaned in the live object.b3 then reads a zero-byte file into a non-nil slice and blobfs rejects every bucket operation with
failed to parse CA certificate, breaking avatars, attachments, LFS and client-org deletion.objstore-cred.yamlneeds no change — its guard is already correct as of 802ccc5, which is an ancestor of v2026.7.10. Not emitting the path is what makes the orphaned key inert.Verified with
helm templateagainst a live HelmRelease's values:CA_CERT_DATA→ key absentCA_CERT_DATAset →CA_CERT_PATH = /data/credentials/ca.crtprovider=gcs,s3=null→ key absent, no nil dereferenceCompanion fix: appscode-cloud/b3#1619.