Skip to content

Fix enum values containing spaces in the column editor - #3200

Closed
HarshMN2345 wants to merge 18 commits into
mainfrom
codex/fix-enum-elements
Closed

HarshMN2345 wants to merge 18 commits into
mainfrom
codex/fix-enum-elements

Conversation

@HarshMN2345

@HarshMN2345 HarshMN2345 commented Sep 15, 2026

Copy link
Copy Markdown
Member

Enum values such as Nizhny Novgorod and New York, NY were split into separate values when typed or pasted into the column editor. Use a dedicated enum control that preserves complete values, confirms them with Enter, Add, or blur, and retains the 255-character limit. Keep the default selection consistent when an allowed value is removed.

Closes appwrite/appwrite#7171.

Validation:

  • Original component regression failed before the fix.
  • 24 focused component and create/edit SDK request tests pass, covering spaces, punctuation, loaded values, duplicates, Unicode limits, native validation, keyboard/focus behavior, IME composition, disabled controls, and default selection.
  • All 315 unit/component tests pass locally and in GitHub CI. Formatting, dependency audit, Svelte check, lint, and the production build pass with existing warnings.
  • Isolated headless Chromium passes complete-value entry, punctuation, actual native pattern and 255- and 256-character ASCII, CJK, and emoji boundaries, trim, Tab, focus restoration, and form submission without external requests.
  • The E2E workflow succeeds: 2 staging journeys pass on the first attempt and 1 passes on retry. The console-stage deployment check passes. Staging journeys were not executed locally.

@appwrite

appwrite Bot commented Sep 15, 2026

Copy link
Copy Markdown

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code

Tip

GraphQL API works alongside REST and WebSocket protocols

@HarshMN2345
HarshMN2345 marked this pull request as ready for review September 15, 2026 07:45
@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule violations.

Summary

This PR replaces the generic tags input with a dedicated enum-value editor that preserves spaces and punctuation, enforces the 255-character limit, handles keyboard, blur, IME, and disabled states, and clears defaults removed from the allowed values.

  • Adds complete-value entry through Enter, Add, and blur.
  • Preserves loaded values and prevents exact duplicates.
  • Keeps default selection synchronized with the available enum values.
  • Adds component and SDK-boundary regression coverage.
  • Since the previous review, removes the implementation-coupled assertion of the exact HTML pattern string.

Reviews (2) · Last reviewed commit: "test(databases): assert enum validation ..."

@HarshMN2345

Copy link
Copy Markdown
Member Author

Closing this, as it’s already fixed in the new Console. The legacy Console is being deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Can't add an enum with a space

1 participant