Skip to content

Use staticmethod for Bootloader.get_default #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
Aug 3, 2026
+5 −5
Merged

Use staticmethod for Bootloader.get_default #4690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions archinstall/lib/models/bootloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ def is_uefi_only(self) -> bool:
def json(self) -> str:
return self.value

@classmethod
def get_default(cls, uefi: bool, skip_boot: bool = False) -> Self:
@staticmethod
def get_default(uefi: bool, skip_boot: bool = False) -> Bootloader:
if skip_boot:
return cls.NO_BOOTLOADER
return Bootloader.NO_BOOTLOADER
elif uefi:
return cls.Systemd
return Bootloader.Systemd
else:
return cls.Grub
return Bootloader.Grub

@classmethod
def from_arg(cls, bootloader: str, skip_boot: bool) -> Self:
Expand Down